GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add support for visiting fragment definitions in QueryVisitor. by tsroka · Pull Request #1445 · graphql-java/graphql-java

Conversation

@tsroka

@tsroka tsroka commented Mar 5, 2019

Copy link
Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Tomek Sroka
Add support for visiting fragments in QueryVisitior.
3ad4dd6
bbakerman
bbakerman approved these changes Mar 7, 2019
View reviewed changes

@bbakerman bbakerman left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
andimarek
andimarek requested changes Mar 10, 2019
View reviewed changes

@andimarek andimarek left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ... see my comments about naming

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/main/java/graphql/analysis/QueryVisitor.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/main/java/graphql/analysis/QueryVisitorFragmentEnvironment.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/main/java/graphql/analysis/QueryVisitorFragmentEnvironmentImpl.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
@andimarek andimarek added this to the 12.0 milestone Mar 10, 2019
Tomek Sroka added 3 commits March 11, 2019 13:33
Tomek Sroka
Add support for visiting fragments in QueryVisitior. PR feedback
48394db
Tomek Sroka
Merge remote-tracking branch 'origin/master' into visit-fragments
1529774
Tomek Sroka
Add support for visiting fragments in QueryVisitior. PR feedback
81004f5
@tsroka

tsroka commented Mar 11, 2019

Copy link
Copy Markdown
Author

nice ... see my comments about naming

Renamed as per your comments and added #toString
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andimarek andimarek changed the title Add support for visiting fragments in QueryVisitor. Add support for visiting fragment definitions in QueryVisitor. Mar 11, 2019
andimarek
andimarek requested changes Mar 11, 2019
View reviewed changes

@andimarek andimarek left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo ... otherwise ready to be merged

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/test/groovy/graphql/analysis/QueryTraversalTest.groovy Outdated
import static java.util.Collections.emptyMap

class QueryTraversalTest extends Specification {
class QueryTrqaversalTest extends Specification {

@andimarek andimarek Mar 11, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Tomek Sroka
Add support for visiting fragments in QueryVisitior. PR feedback
8b58e3e
@andimarek
andimarek merged commit 52a7b6e into graphql-java:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andimarek andimarek andimarek requested changes
@bbakerman bbakerman bbakerman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

12.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tsroka @bbakerman @andimarek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.