GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Introduce a GraphqlErrorException for Kotlin users and generally. by bbakerman · Pull Request #1743 · graphql-java/graphql-java

Conversation

@bbakerman

@bbakerman bbakerman commented Jan 15, 2020

Copy link
Copy Markdown
Member

This is useful for error specialisations as well addressing as #1690

I am still waiting on Kotlin experts on why this helps

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bbakerman
Introduce a GraphqlErrorException for Kotlin users and a as a general…
ae9f6e0 
… purpose exception that can be an error
@bbakerman bbakerman added this to the 14.0 milestone Jan 15, 2020
@bbakerman
bbakerman requested a review from andimarek January 15, 2020 12:31
@bbakerman
Merge remote-tracking branch 'origin/master' into graphql-error-excep…
e0e3b63 
…tion
@bbakerman

bbakerman commented Jan 17, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

To use this in kotlin one would do

class MyException(message: String?, val extraProps: String) :
    GraphqlErrorException(newErrorException().message(message)) {

    override val message: String?
        get() {
            return "special code here : " + super.message
        }
}

That is this has extra properties AND if you really wanted to override the getMessage method in GraphqlError and the magic message property in Kotlin Throwable
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bbakerman
PR feedback and now more generic
2d6398d
@bbakerman
bbakerman merged commit 578985f into master Jan 17, 2020
@andimarek andimarek mentioned this pull request Jan 19, 2020
Kotlin compiler error: inherited platform declaration clashes #1690
Closed
@andimarek
andimarek deleted the graphql-error-exception branch June 5, 2020 10:43
@Satook Satook mentioned this pull request Jul 14, 2022
GraphQLError in Kotlin is cause an Accidental Override #1022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andimarek andimarek Awaiting requested review from andimarek

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@bbakerman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.