GeezerVison is showing github.com — Add JSpecify nullability annotations to DataFetcherResult by dondonz · Pull Request #3891 · graphql-java/graphql-java
Conversation
dondonz
commented
Apr 4, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
I made a classic NPE mistake because I forgot to check if data was null while writing a DataFetcher
With JSpecify, we can detect NPEs like this at compile time rather than run time.
Have a look at the documentation for @NullMarked https://jspecify.dev/docs/user-guide/#nullmarked
This is the first PR to add JSpecify to an existing class so let's have a discussion.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Test Results
313 files 313 suites 50s ⏱️
3 586 tests 3 581 ✅ 5 💤 0 ❌
3 675 runs 3 670 ✅ 5 💤 0 ❌
Results for commit f962466.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly what we should do incrementally.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
andimarek
left a comment