GeezerVison is showing github.com — Fix and improve EngineRunning state by andimarek · Pull Request #3911 · graphql-java/graphql-java
Conversation
andimarek
commented
Apr 10, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Because the engine state updates are side effects, it can happen that the last "NOT_RUNNING" happens after the overall CompletableFuture<ExecutionResult> is completed.
As this is very counterintuitive this PR fixes that edge case with observing the CompletableFuture<ExecutionResult> explicitly.
It also make explicit states for Start and finish the engine.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
fixes cases where the CF<ER> is finished before the observer is called for the last time
Test Results
313 files 313 suites 53s ⏱️
3 588 tests 3 583 ✅ 5 💤 0 ❌
3 677 runs 3 672 ✅ 5 💤 0 ❌
Results for commit 71c8032.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.