GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ExecutionStepInfo now has a direct transform without a Builder by bbakerman · Pull Request #3934 · graphql-java/graphql-java

Conversation

@bbakerman

@bbakerman bbakerman commented Apr 28, 2025

Copy link
Copy Markdown
Member

This is really 1% stuff. Its debatably faster BUT it uses (slightly) less memory and thats a good thing at scale

Benchmark                                                        (howManyItems)   Mode  Cnt    Score    Error  Units
ExecutionStepInfoBenchmark.benchMarkBuilderThroughput                   1000000  thrpt    4  376.814 ±  7.136  ops/s
ExecutionStepInfoBenchmark.benchMarkBuilderThroughput                   2000000  thrpt    4  188.889 ±  2.585  ops/s
ExecutionStepInfoBenchmark.benchMarkDirectConstructorThroughput         1000000  thrpt    4  379.725 ± 13.369  ops/s
ExecutionStepInfoBenchmark.benchMarkDirectConstructorThroughput         2000000  thrpt    4  191.496 ±  1.785  ops/s

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bbakerman
ExecutionStepInfo now has a direct transform without a Builder
3e004e9
@bbakerman bbakerman added the performance work that is primarily targeted as performance improvements label Apr 28, 2025
@bbakerman
bbakerman requested a review from andimarek April 28, 2025 02:16
@bbakerman
ExecutionStepInfo now has a direct transform without a Builder - tweak
237d6bb
@github-actions

github-actions Bot commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

Test Results

  312 files    312 suites   54s ⏱️
3 581 tests 3 576 ✅ 5 💤 0 ❌
3 670 runs  3 665 ✅ 5 💤 0 ❌

Results for commit 237d6bb.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bbakerman
bbakerman requested a review from dondonz April 28, 2025 04:41
@bbakerman bbakerman mentioned this pull request Apr 29, 2025
1% possible memory and cpu improvements #3939
Open
@dondonz dondonz modified the milestones: 24.x non-breaking changes and bugfixes, 25.x breaking changes, 24.0 May 11, 2025
dondonz
dondonz approved these changes May 14, 2025
View reviewed changes
@dondonz
dondonz merged commit 1a760d7 into master May 14, 2025
@dondonz dondonz mentioned this pull request May 15, 2025
Cherry pick 3934 for execution step info builder changes #3970
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dondonz dondonz dondonz approved these changes
@andimarek andimarek Awaiting requested review from andimarek

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

performance work that is primarily targeted as performance improvements

Projects

None yet

Milestone

24.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bbakerman @dondonz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.