GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — avoid wrapping materialized fieldValueObject in a completable future by samuelAndalon · Pull Request #3944 · graphql-java/graphql-java

Conversation

@samuelAndalon

@samuelAndalon samuelAndalon commented Apr 30, 2025

Copy link
Copy Markdown

cherry pick #3943 since this release was focused on avoid wrapping materialized objects in CFs
https://github.com/graphql-java/graphql-java/releases/tag/v22.0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Samuel Vazquez
avoid wrapping materialized fieldValueObject in a completable future
9dbc4a9
@bbakerman bbakerman added the performance work that is primarily targeted as performance improvements label May 1, 2025
@bbakerman
bbakerman self-requested a review May 1, 2025 03:59
@dondonz dondonz modified the milestones: 22.4, 23.2 May 11, 2025
dondonz
dondonz approved these changes May 11, 2025
View reviewed changes
@dondonz
dondonz merged commit 059a0ff into graphql-java:22.x May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dondonz dondonz dondonz approved these changes
@bbakerman bbakerman Awaiting requested review from bbakerman

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

performance work that is primarily targeted as performance improvements

Projects

None yet

Milestone

22.4

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@samuelAndalon @dondonz @bbakerman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.