GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — New Exhaustion based data loader dispatching strategy by andimarek · Pull Request #4130 · graphql-java/graphql-java

Conversation

@andimarek

@andimarek andimarek commented Sep 27, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR introduces an alternative data loader strategy that mimics in some way how the JS event loop Data Loader dispatcher works:

Instead of dispatching per Level (the current default) this strategy dispatches as soon as the engine is not "busy" anymore.

Busy here means specifically:

  • No sub selection is currently being fetched (on any level
  • No completion is currently executed
  • No Data Loader is currently dispatched

This also handles "chained data loaders": data loaders being used after another data loader inside one DataFetcher.

This new dispatching strategy can be enabled by setting

  graphQLContext.put(DataLoaderDispatchingContextKeys.ENABLE_DATA_LOADER_EXHAUSTED_DISPATCHING, true);

or

 GraphQL.unusualConfiguration(graphqlContext).dataloaderConfig().enableDataLoaderExhaustedDispatching(true)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
andimarek added 4 commits September 27, 2025 10:58
@andimarek
wip
2cb5354
@andimarek
working exhausted strategy
0407946
@andimarek
cleanup
2e5c616
@andimarek
cleanup
f952bf1
@github-actions

github-actions Bot commented Sep 27, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Test Results

  325 files    325 suites   5m 7s ⏱️
5 189 tests 5 183 ✅ 6 💤 0 ❌
5 278 runs  5 272 ✅ 6 💤 0 ❌

Results for commit 6c9d267.

♻️ This comment has been updated with latest results.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

andimarek added 8 commits September 27, 2025 20:25
@andimarek
test
5f27d3d
ambiguous config check
@andimarek
tests
dab44bf
@andimarek
testing
583c278
@andimarek
testing and fixes delayed list of objects case
8a24dca
@andimarek
testing
f40a4e5
@andimarek
testing
8ce7be7
@andimarek
testing
f0b2b09
@andimarek
testing
570e5c6
@andimarek andimarek added this to the 25.x breaking changes milestone Sep 27, 2025
andimarek added 5 commits September 28, 2025 08:08
@andimarek
remove not needed start stop complete call
860a0bd
@andimarek
make test stable
b4f1d4b
@andimarek
no field fetching callback for execute object needed
a96ba08
@andimarek
improve performance by not handling executeObject (and field fetched …
563abe9
…on executeObject) because it is not needed
@andimarek
performance improvements
6c9d267
@andimarek
andimarek merged commit 45a7d59 into master Sep 28, 2025
bbakerman
bbakerman reviewed Sep 29, 2025
View reviewed changes
Comment thread src/main/java/graphql/execution/DataLoaderDispatchStrategy.java

}

default void startComplete(ExecutionStrategyParameters parameters) {

@bbakerman bbakerman Sep 29, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javadoc would be nice

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbakerman bbakerman bbakerman left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

25.x breaking changes

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@andimarek @bbakerman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.