GeezerVison is showing github.com — New Exhaustion based data loader dispatching strategy by andimarek · Pull Request #4130 · graphql-java/graphql-java
Conversation
andimarek
commented
Sep 27, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
This PR introduces an alternative data loader strategy that mimics in some way how the JS event loop Data Loader dispatcher works:
Instead of dispatching per Level (the current default) this strategy dispatches as soon as the engine is not "busy" anymore.
Busy here means specifically:
- No sub selection is currently being fetched (on any level
- No completion is currently executed
- No Data Loader is currently dispatched
This also handles "chained data loaders": data loaders being used after another data loader inside one DataFetcher.
This new dispatching strategy can be enabled by setting
graphQLContext.put(DataLoaderDispatchingContextKeys.ENABLE_DATA_LOADER_EXHAUSTED_DISPATCHING, true);
or
GraphQL.unusualConfiguration(graphqlContext).dataloaderConfig().enableDataLoaderExhaustedDispatching(true)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Test Results
325 files 325 suites 5m 7s ⏱️
5 189 tests 5 183 ✅ 6 💤 0 ❌
5 278 runs 5 272 ✅ 6 💤 0 ❌
Results for commit 6c9d267.
♻️ This comment has been updated with latest results.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…on executeObject) because it is not needed
|
|
|
|
|
}
|
|
|
|
|
|
default void startComplete(ExecutionStrategyParameters parameters) {
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.