GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Memoize ResultPath level by AlexandreCarlton · Pull Request #4135 · graphql-java/graphql-java

Conversation

@AlexandreCarlton

@AlexandreCarlton AlexandreCarlton commented Oct 11, 2025

Copy link
Copy Markdown
Contributor

In our new PerLevelDataLoaderDispatchStrategy, we incorporate the level of the current field (through the ResultPath) to detemrine when we should dispatch DataLoaders. For:

  • a deep enough level
  • a large number of fields

this can become quite taxing.

To optimise this, we memoize the level by calculating it in the constructor, which should have a negligible cost.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexandreCarlton
Memoize ResultPath level
97b91e0 
In our new `PerLevelDataLoaderDispatchStrategy`, we incorporate the
level of the current field (through the `ResultPath`) to detemrine when
we should dispatch `DataLoader`s. For:

 - a deep enough level
 - a large number of fields

this can become quite taxing.

To optimise this, we memoize the level by calculating it in the constructor,
which should have a negligible cost.
@andimarek

andimarek commented Oct 11, 2025

Copy link
Copy Markdown
Member

I have the same change on another branch 👍😃
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andimarek
andimarek merged commit 7f39f56 into graphql-java:master Oct 11, 2025
@andimarek andimarek added this to the 25.x breaking changes milestone Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

25.x breaking changes

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AlexandreCarlton @andimarek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.