GeezerVison is showing github.com — Fix error: Unusable type signature for overload of graphql.schema.SchemaTraverser::depthFirst #4147 by marktech0813 · Pull Request #4165 · graphql-java/graphql-java
Conversation
I found the problematic overload in SchemaTraverser and updated its public API to accept the correct visitor type, ensuring it’s usable outside the class.
This removes the unusable public signature that referenced the private TraverserDelegateVisitor type. All existing internal calls (which pass new TraverserDelegateVisitor(...)) still work because that class implements TraverserVisitor.
Summary:
- Changed SchemaTraverser.depthFirst(Traverser, TraverserDelegateVisitor, ...) to use TraverserVisitor instead, and adjusted the helper accordingly.
- Public API is now usable by callers without referencing a private inner class; no behavior change for existing internal usage.
Contribution by Gittensor, learn more at https://gittensor.io/
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…emaTraverser::depthFirst graphql-java#4147
I found the problematic overload in SchemaTraverser and updated its public API to accept the correct visitor type, ensuring it’s usable outside the class.
This removes the unusable public signature that referenced the private TraverserDelegateVisitor type.
All existing internal calls (which pass new TraverserDelegateVisitor(...)) still work because that class implements TraverserVisitor<GraphQLSchemaElement>.
Summary:
- Changed SchemaTraverser.depthFirst(Traverser, TraverserDelegateVisitor, ...) to use TraverserVisitor<GraphQLSchemaElement> instead, and adjusted the helper accordingly.
- Public API is now usable by callers without referencing a private inner class; no behavior change for existing internal usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
bbakerman
Awaiting requested review from bbakerman
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.