GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Build and test using Java 25 by yeikel · Pull Request #4173 · graphql-java/graphql-java

Conversation

@yeikel

@yeikel yeikel commented Nov 16, 2025

Copy link
Copy Markdown
Contributor

Updates the CI and the build to use Java 25

Closes #4119

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
reneleonhardt reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@yeikel
Build and test using Java 25
865bf67
@yeikel yeikel mentioned this pull request Nov 16, 2025
Build and Test using Java 25 #4119
Closed
@andimarek
andimarek requested a review from Copilot November 17, 2025 02:27
Copilot started reviewing on behalf of andimarek November 17, 2025 02:27
View session
Copilot finished reviewing on behalf of andimarek November 17, 2025 02:28
Copilot AI reviewed Nov 17, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the build configuration and CI workflows to use Java 25 as the primary JDK, while adding Java 21 to the test matrix to ensure backward compatibility testing.

  • Updates GitHub Actions workflows to use JDK 25 instead of JDK 21
  • Adds a new testWithJava21 Gradle task to test backward compatibility with Java 21
  • Updates CI test matrices and test result paths to include Java 21 tests

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
build.gradle Adds testWithJava21 test task and makes it a dependency of the main test task
.github/workflows/release.yml Updates JDK version from 21 to 25 for release builds
.github/workflows/pull_request.yml Updates JDK to 25, adds Java 21 testing to matrix, and includes Java 21 test results
.github/workflows/master.yml Updates JDK to 25, adds Java 21 testing to matrix, and includes Java 21 test results

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@reneleonhardt

reneleonhardt commented Nov 17, 2025

Copy link
Copy Markdown

Has testWithJava25 specifically not been added?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@yeikel

yeikel commented Nov 17, 2025

Copy link
Copy Markdown
Contributor Author

Has testWithJava25 specifically not been added?

Based on the previous pattern, my understanding of the build is that this will happen by default
reneleonhardt reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dondonz dondonz modified the milestones: 26.x, 26.x breaking changes, 25.1 bugfix & non-breaking changes Dec 4, 2025
dondonz
dondonz approved these changes Dec 7, 2025
View reviewed changes

@dondonz dondonz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Could you update for the merge conflict?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@yeikel
Merge branch 'master' into java25
601e74f
@yeikel

yeikel commented Dec 7, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for the PR. Could you update for the merge conflict?

It should be ready now. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@reneleonhardt

reneleonhardt commented Dec 8, 2025

Copy link
Copy Markdown

Has testWithJava25 specifically not been added?

Based on the previous pattern, my understanding of the build is that this will happen by default

Could you log the actual JDK being tested just to be sure?

test {
    doFirst {
        println "Running tests with JDK ${System.getProperty('java.version')}"
    }
}
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@yeikel
Print the java version under test
30b14e3
@yeikel

yeikel commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author

Has testWithJava25 specifically not been added?

Based on the previous pattern, my understanding of the build is that this will happen by default

Could you log the actual JDK being tested just to be sure?

test {
    doFirst {
        println "Running tests with JDK ${System.getProperty('java.version')}"
    }
}

Thanks, I applied your feedback. See https://github.com/graphql-java/graphql-java/actions/runs/20075548260/job/57588814897?pr=4173#step:6:1567
reneleonhardt reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
andimarek added 2 commits January 20, 2026 10:53
@andimarek
Merge origin/master into java25
1ef99fa 
Resolve conflicts in workflow files:
- Keep testWithJava21 test results
- Keep javadoc job, updated to use JDK 25
@andimarek
Remove debug output and update AGENTS.md for Java 21 tests
20856c5 
- Remove test doFirst block that printed JDK version
- Add testWithJava21 exclusion to AGENTS.md test command
@andimarek andimarek added the not release related changes which are not released (for example unit tests or docs) label Jan 20, 2026
@andimarek
andimarek merged commit e5f21b8 into graphql-java:master Jan 20, 2026
6 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@yeikel
yeikel deleted the java25 branch January 20, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dondonz dondonz dondonz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

not release related changes which are not released (for example unit tests or docs)

Projects

None yet

Milestone

25.1 bugfix & non-breaking changes

Development

Successfully merging this pull request may close these issues.

Build and Test using Java 25

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@yeikel @reneleonhardt @dondonz @andimarek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.