GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — #4182 - code built schemas should perform deprecated non null field validations as well as SDL built ones by bbakerman · Pull Request #4194 · graphql-java/graphql-java

Conversation

@bbakerman

@bbakerman bbakerman commented Dec 18, 2025

Copy link
Copy Markdown
Member

See #4182

This fixes the two paths to deprecation

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
bbakerman added 2 commits December 19, 2025 10:22
@bbakerman
#4182 - code built schemas should perform deprecated non null field v…
afbcd52
…alidations as well as SDL built ones
@bbakerman
#4182 - code built schemas should perform deprecated non null field v…
dd5bc03
…alidations as well as SDL built ones
@github-actions

github-actions Bot commented Dec 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Test Results

  327 files  ±0    327 suites  ±0   5m 10s ⏱️ +2s
5 222 tests +1  5 214 ✅ +1  8 💤 ±0  0 ❌ ±0 
5 311 runs  +1  5 303 ✅ +1  8 💤 ±0  0 ❌ ±0 

Results for commit dd5bc03. ± Comparison against base commit 021fe1b.

This pull request removes 171 and adds 148 tests. Note that renamed tests count towards both.
	?

	, expected: combo-\"\\\b\f\n\r\t, #4]
                __schema { types { fields { args { type { name fields { name }}}}}}
                __schema { types { fields { type { name fields { name }}}}}
                __schema { types { inputFields { type { inputFields { name }}}}}
                __schema { types { interfaces { fields { type { interfaces { name } } } } } }
                __schema { types { name} }
                __type(name : "t") { name }
                a1: __schema { types { name} }
                a1: __type(name : "t") { name }
…
graphql.ScalarsBooleanTest ‑ parseValue throws exception for invalid input <java.lang.Object@ac92a0e>
graphql.ScalarsBooleanTest ‑ serialize throws exception for invalid input <java.lang.Object@129253ca>
graphql.ScalarsIDTest ‑ parseValue allows any object via String.valueOf <java.lang.Object@4fdbb20d>
graphql.ScalarsIDTest ‑ serialize allows any object via String.valueOf <java.lang.Object@5eef85d2>
graphql.ScalarsIntTest ‑ parseValue throws exception for invalid input <java.lang.Object@26d41169>
graphql.ScalarsIntTest ‑ serialize throws exception for invalid input <java.lang.Object@3095a7>
graphql.analysis.QueryTraverserTest ‑ builder doesn't allow null arguments [document: Document{definitions=[OperationDefinition{name='null', operation=QUERY, variableDefinitions=[], directives=graphql.language.NodeUtil$DirectivesHolder@2cd6a2c9, selectionSet=SelectionSet{selections=[Field{name='foo', alias='null', arguments=[], directives=graphql.language.NodeUtil$DirectivesHolder@296ee8c, selectionSet=null}]}}]}, operationName: foo, root: Field{name='null', alias='null', arguments=[], directives=graphql.language.NodeUtil$DirectivesHolder@7a1dc9c7, selectionSet=null}, rootParentType: null, fragmentsByName: [:], #3]
graphql.analysis.QueryTraverserTest ‑ builder doesn't allow null arguments [document: Document{definitions=[OperationDefinition{name='null', operation=QUERY, variableDefinitions=[], directives=graphql.language.NodeUtil$DirectivesHolder@64e78f1e, selectionSet=SelectionSet{selections=[Field{name='foo', alias='null', arguments=[], directives=graphql.language.NodeUtil$DirectivesHolder@5d56778, selectionSet=null}]}}]}, operationName: foo, root: Field{name='null', alias='null', arguments=[], directives=graphql.language.NodeUtil$DirectivesHolder@51952cdd, selectionSet=null}, rootParentType: Mock for type 'GraphQLObjectType', fragmentsByName: null, #2]
graphql.analysis.QueryTraverserTest ‑ builder doesn't allow null arguments [document: Document{definitions=[OperationDefinition{name='null', operation=QUERY, variableDefinitions=[], directives=graphql.language.NodeUtil$DirectivesHolder@72401eaa, selectionSet=SelectionSet{selections=[Field{name='foo', alias='null', arguments=[], directives=graphql.language.NodeUtil$DirectivesHolder@1353d323, selectionSet=null}]}}]}, operationName: null, root: Field{name='null', alias='null', arguments=[], directives=graphql.language.NodeUtil$DirectivesHolder@7dea3b84, selectionSet=null}, rootParentType: null, fragmentsByName: null, #0]
graphql.analysis.QueryTraverserTest ‑ builder doesn't allow null arguments [document: Document{definitions=[OperationDefinition{name='null', operation=QUERY, variableDefinitions=[], directives=graphql.language.NodeUtil$DirectivesHolder@fadcfdd, selectionSet=SelectionSet{selections=[Field{name='foo', alias='null', arguments=[], directives=graphql.language.NodeUtil$DirectivesHolder@26adfc0, selectionSet=null}]}}]}, operationName: foo, root: Field{name='null', alias='null', arguments=[], directives=graphql.language.NodeUtil$DirectivesHolder@48fdbb9e, selectionSet=null}, rootParentType: null, fragmentsByName: null, #1]
…

♻️ This comment has been updated with latest results.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bbakerman bbakerman added this to the 26.x breaking changes milestone Dec 18, 2025
@andimarek
andimarek merged commit 1a80205 into master Jan 21, 2026
5 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

26.x is a breaking change release (ot...

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bbakerman @andimarek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.