GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Add JSpecify annotations to normalized, schema, and util classes (Wave 5) by dondonz · Pull Request #4303 · graphql-java/graphql-java Conversation
|
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (9 classes)
AstTransformer — method details
NormalizedField — method details
NormalizedOperationToAstCompiler — method details
Parser.1 — method details
SchemaPrinter — method details
QueryGenerator — method details
|
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
TreeParallelTransformer only set List.class as a context var but never NodeAdapter.class. After JSpecify annotations wrapped getVar() calls with assertNotNull(), this caused test failures in TreeParallelTransformerTest and AstTransformerTest. Co-Authored-By: Claude Opus 4.6 <[email protected]>
dondonz
commented
Mar 7, 2026
| "graphql.analysis.QueryReducer", | ||
| "graphql.analysis.QueryTransformer", | ||
| "graphql.analysis.QueryTraversalOptions", | ||
| "graphql.analysis.QueryTraverser", |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some classes left in this diff - these are in other currently open PRs
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
# Conflicts: # .claude/commands/jspecify-annotate.md # src/main/java/graphql/execution/ExecutionContext.java # src/main/java/graphql/introspection/GoodFaithIntrospection.java # src/main/java/graphql/normalized/ExecutableNormalizedOperation.java # src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy
# Conflicts: # src/main/java/graphql/execution/directives/QueryAppliedDirectiveArgument.java # src/main/java/graphql/execution/preparsed/PreparsedDocumentEntry.java # src/main/java/graphql/util/Anonymizer.java
Removes 31 classes from JSPECIFY_EXEMPTION_LIST in JSpecifyAnnotationsCheck.groovy that have already been annotated with @NullMarked/@NullUnmarked across the wave 4 work. The "exempted classes should not be annotated" archunit test was failing because these classes were both exempt and annotated. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
# Conflicts: # src/main/java/graphql/language/AstSignature.java # src/main/java/graphql/language/VariableDefinition.java
# Conflicts: # .claude/commands/jspecify-annotate.md # src/main/java/graphql/execution/ExecutionContext.java # src/main/java/graphql/execution/SubscriptionExecutionStrategy.java # src/main/java/graphql/execution/directives/QueryAppliedDirectiveArgument.java # src/main/java/graphql/execution/preparsed/PreparsedDocumentEntry.java # src/main/java/graphql/introspection/GoodFaithIntrospection.java # src/main/java/graphql/language/VariableDefinition.java # src/main/java/graphql/normalized/ExecutableNormalizedOperation.java # src/main/java/graphql/util/Anonymizer.java # src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy
# Conflicts: # src/main/java/graphql/introspection/GoodFaithIntrospection.java # src/main/java/graphql/language/AstTransformer.java # src/main/java/graphql/language/NodeTraverser.java # src/main/java/graphql/normalized/ExecutableNormalizedOperation.java # src/main/java/graphql/schema/idl/SchemaPrinter.java # src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy
dondonz
marked this pull request as ready for review
May 24, 2026 00:33
dondonz
marked this pull request as draft
May 24, 2026 06:05
This branch has not been deployed
No deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
No reviewsUh oh!
There was an error while loading. Please reload this page.
Assignees
No one assignedLabels
None yet
Projects
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.