GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix input cycle validation for non-null lists by andimarek · Pull Request #4386 · graphql-java/graphql-java

Conversation

@andimarek

@andimarek andimarek commented May 19, 2026

Copy link
Copy Markdown
Member

Summary

  • treat non-null list input fields as breaking unbroken input cycles
  • add SDL regression coverage for Schema generator reports false positive unsatisfiable input object cycle #4214

Verification

  • Confirmed the new regression test fails on current master with: [self!] forms an unsatisfiable cycle
  • ./gradlew test --tests graphql.schema.validation.NoUnbrokenInputCyclesTest
  • ./gradlew test --tests 'graphql.schema.validation.*'

Fixes #4214

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafeArnold reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@andimarek andimarek mentioned this pull request May 19, 2026
Schema generator reports false positive unsatisfiable input object cycle #4214
Closed
@github-actions

github-actions Bot commented May 19, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Test Report

Test Results

Java Version Total Passed Failed Errors Skipped
Java 11 5828 (+2 🟢) 5772 (+2 🟢) 0 (±0) 0 (±0) 56 (±0)
Java 17 5828 (+2 🟢) 5771 (+2 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 21 5828 (+2 🟢) 5771 (+2 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 25 5828 (+2 🟢) 5771 (+2 🟢) 0 (±0) 0 (±0) 57 (±0)
jcstress 32 (±0) 32 (±0) 0 (±0) 0 (±0) 0 (±0)
Total 23344 (+8 🟢) 23117 (+8 🟢) 0 (±0) 0 (±0) 227 (±0)

Code Coverage (Java 25)

Metric Covered Missed Coverage vs Master
Lines 29551 3130 90.4% ±0.0%
Branches 8669 1533 85.0% ±0.0%
Methods 7892 1210 86.7% ±0.0%

Changed Class Coverage (1 class)

Class Line Branch Method
g.s.v.NoUnbrokenInputCycles +2.6% 🟢 +4.4% 🟢 ±0.0%

Full HTML report: build artifact jacoco-html-report

Updated: 2026-05-20 00:55:07 UTC
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andimarek

andimarek commented May 20, 2026

Copy link
Copy Markdown
Member Author

Double-checked against the current GraphQL draft spec. Example 83 is exactly the case covered by this PR:

input Example { self: [Example!]! value: String }

The spec says this circular reference is valid because self may be an empty list, and the Input Object type validation rule says a recursive chain is valid when at least one field in the chain is nullable or a List type.

Spec reference: https://spec.graphql.org/draft/#sec-Input-Objects.Circular-References
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andimarek
Fix input cycle validation for non-null lists
63cdef1
@andimarek
andimarek force-pushed the fix-4214-input-list-cycle branch from b748fb8 to 63cdef1 Compare May 20, 2026 00:31
@andimarek
andimarek enabled auto-merge (squash) May 20, 2026 00:34
@andimarek
andimarek merged commit 7e0b1c1 into master May 20, 2026
15 of 20 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@andimarek andimarek mentioned this pull request Aug 20, 2026
Backport 26.1: Fix input cycle validation for non-null lists #4448
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Schema generator reports false positive unsatisfiable input object cycle

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@andimarek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.