GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Backport 26.1: Fix schema rebuild after root type deletion by andimarek · Pull Request #4446 · graphql-java/graphql-java Conversation
Member
Backport of #4390 to the SummaryFixes #3384. The core issue is that a built
In the #3384 repro, The catch is that schema build collection intentionally traverses This is what the code calls an indirect strong reference:
The same original-reference versus resolved-accessor split exists for unions and interface inheritance:
This does not keep every deleted-path extra type alive. It only preserves resolved named types that are still referenced by a schema element that remains reachable in the rebuilt schema. Repro CoverageAdds #3384 Spock coverage for these schema rebuild cases:
The object/interface case is covered through both paths:
The union and interface-inheritance cases specifically prove why Before the collector change, these cases fail during rebuild with an NPE in Local Test StabilityThis PR also keeps the local build cleanup from the previous version of #4390: Verification./gradlew test --tests "graphql.schema.impl.SchemaUtilTest.can rebuild schema after removing root type that made an implemented interface reachable" --tests "graphql.schema.impl.SchemaUtilTest.can transform schema after deleting root type that made an implemented interface reachable" --tests "graphql.schema.impl.SchemaUtilTest.can rebuild schema after removing root type that made a union member reachable" --tests "graphql.schema.impl.SchemaUtilTest.can rebuild schema after removing root type that made an interface implemented by another interface reachable" ./gradlew test --tests graphql.schema.impl.SchemaUtilTest Also ran: git diff --check
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions* Make generated annotation marking idempotent * Add failing schema rebuild repros for issue 3384 * Fix type collection for resolved schema references * Add schema rebuild coverage for union and interface references * Remove issue annotations from schema rebuild tests * Rename schema rebuild test helpers
|
There was an error while loading. Please reload this page.
Test ReportTest Results
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…o-26.x # Conflicts: # build.gradle
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.