GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Simplify directive cycle detection by andimarek · Pull Request #4459 · graphql-java/graphql-java

Conversation

@andimarek

@andimarek andimarek commented Aug 23, 2026

Copy link
Copy Markdown
Member

Summary

  • derive directive and input-type references on demand instead of precomputing a second graph
  • use one ordered active path for cycle detection and diagnostic formatting
  • preserve directive-definition, input object, enum, scalar, and extension cycle handling on master
  • consolidate duplicate cycle tests and add acyclic plus master-specific type coverage

This follows up on the simplification made in #4451 for 26.x, adapted to master’s broader directive-definition and input-type cycle support.

Testing

  • ./gradlew test --tests graphql.schema.idl.SchemaTypeDirectivesCheckerTest --tests graphql.schema.idl.SchemaGeneratorTest --tests graphql.schema.idl.DirectivesOnDirectiveDefinitionsTest
  • ./gradlew clean test (5,753 tests)
  • ./gradlew check -x test -x testng

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andimarek
Simplify directive cycle detection
12ba185
@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Test Report

Test Results

Java Version Total Passed Failed Errors Skipped
Java 11 5943 (+3 🟢) 5887 (+3 🟢) 0 (±0) 0 (±0) 56 (±0)
Java 17 5943 (+3 🟢) 5886 (+3 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 21 5943 (+3 🟢) 5886 (+3 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 25 5943 (+3 🟢) 5886 (+3 🟢) 0 (±0) 0 (±0) 57 (±0)
jcstress 32 (±0) 32 (±0) 0 (±0) 0 (±0) 0 (±0)
Total 23804 (+12 🟢) 23577 (+12 🟢) 0 (±0) 0 (±0) 227 (±0)

Code Coverage (Java 25)

Metric Covered Missed Coverage vs Master
Lines 30070 3117 90.6% ±0.0%
Branches 8803 1517 85.3% ±0.0%
Methods 8024 1205 86.9% ±0.0%

Changed Class Coverage (4 classes)

Class Line Branch Method
g.s.i.e.MissingScalarImplementationError +100.0% 🟢 ±0.0% +100.0% 🟢
g.s.i.SchemaTypeChecker +0.6% 🟢 +5.0% 🟢 ±0.0%
g.s.i.SchemaTypeDirectivesChecker ±0.0% ±0.0% -1.4% 🔴
g.s.i.SchemaTypeExtensionsChecker +0.5% 🟢 ±0.0% +1.5% 🟢
SchemaTypeDirectivesChecker — method details
Method Line Branch
directiveReferences new 100.0% —
typeReferences new 100.0% 100.0%
recordReference new 100.0% —
checkIndirectDirectiveCycles new 100.0% 100.0%
checkDirectiveReferencesForCycles new 100.0% 100.0%
referencesFor new 100.0% 100.0%
addIndirectDirectiveCycleError new 100.0% 100.0%
firstDirectiveName new 100.0% 100.0%
rotateAndDisplayCycle new 100.0% 100.0%
lambda$typeReferences$2 new 0.0% —
lambda$typeReferences$1 new 100.0% —
lambda$typeReferences$0 new 100.0% —
lambda$directiveReferences$1 new 100.0% —
lambda$directiveReferences$0 new 100.0% —
referencesByName removed removed
recordDirectiveDefinitionReferences removed removed
recordInputTypeReferences removed removed
recordReference removed removed
checkIndirectDirectiveCycles removed removed
checkIndirectDirectiveCycles removed removed
checkIndirectDirectiveCycleReferences removed removed
checkIndirectDirectiveCycleReference removed removed
addIndirectDirectiveCycleError removed removed
directiveCyclePath removed removed
rotateCyclePath removed removed
lambda$recordReference$0 removed removed
lambda$recordInputTypeReferences$7 removed removed
lambda$recordInputTypeReferences$8 removed removed
lambda$recordInputTypeReferences$6 removed removed
lambda$recordInputTypeReferences$4 removed removed
lambda$recordInputTypeReferences$5 removed removed
lambda$recordInputTypeReferences$3 removed removed
lambda$recordInputTypeReferences$1 removed removed
lambda$recordInputTypeReferences$2 removed removed
lambda$recordInputTypeReferences$0 removed removed
lambda$recordDirectiveDefinitionReferences$1 removed removed
lambda$recordDirectiveDefinitionReferences$0 removed removed
lambda$referencesByName$0 removed removed

Full HTML report: build artifact jacoco-html-report

Updated: 2026-08-23 23:11:45 UTC
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@andimarek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.