GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Breaking change for v27: default to exhausted DataLoader dispatching by andimarek · Pull Request #4534 · graphql-java/graphql-java

Conversation

@andimarek

@andimarek andimarek commented Nov 3, 2026

Copy link
Copy Markdown
Member

Breaking change — targeted for GraphQL Java 27. Do not backport to 26.x or earlier.

Use ExhaustedDataLoaderDispatchStrategy instead of PerLevelDataLoaderDispatchStrategy when automatic dispatching is enabled and no strategy is configured. Exhausted dispatching runs queued loads when the tracked fetching/completion work and batch loading are exhausted, and supports chained loads without an opt-in.

Compatibility and migration

  • Dispatch timing and batch composition can change: batches are no longer tied to query levels.

  • Obtain loaders through DataFetchingEnvironment.getDataLoader(...). The default now returns the tracking wrapper; loading directly through the registry or a separately held loader bypasses tracking and can leave requests waiting indefinitely.

  • To retain per-level dispatching for a request:

    GraphQL.unusualConfiguration(executionInput)
            .dataloaderConfig()
            .enableDataLoaderExhaustedDispatching(false);
  • Existing enableDataLoaderChaining(true) continues to select per-level chained dispatching when exhausted dispatching is unset. Explicitly enabling both strategies still fails. Disabling automatic dispatch and requests without a supplied registry still use the no-op strategy.

Implementation and tests

Update strategy selection, loader wrapping, the configuration getter, and Javadoc together. Add selection coverage for queries, mutations, and subscriptions; verify the effective configuration on context builders and contexts, default chained loading, loader wrapping, and the explicit per-level migration path. Migrate the hanging-test fixture to tracked loader access and test it with both strategies. Update the deferred batching assertion to account for the new default's timing.

Validation: ./gradlew --no-daemon test testng jacocoTestReport javadoc passed on Java 25. No per-class coverage regressions against test-baseline.json using the CI comparison rules.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@andimarek
Default to exhausted DataLoader dispatching for v27
849cae8
@andimarek andimarek added the breaking change requires a new major version to be relased label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Test Report

Test Results

Java Version Total Passed Failed Errors Skipped
Java 17 6225 (+47 🟢) 6169 (+47 🟢) 0 (±0) 0 (±0) 56 (±0)
Java 21 6225 (+47 🟢) 6169 (+47 🟢) 0 (±0) 0 (±0) 56 (±0)
Java 25 6225 (+47 🟢) 6169 (+47 🟢) 0 (±0) 0 (±0) 56 (±0)
jcstress 32 (±0) 32 (±0) 0 (±0) 0 (±0) 0 (±0)
Total 18707 (+141 🟢) 18539 (+141 🟢) 0 (±0) 0 (±0) 168 (±0)

Code Coverage (Java 25)

Metric Covered Missed Coverage vs Master
Lines 30327 3078 90.8% ±0.0%
Branches 8962 1504 85.6% ±0.0%
Methods 8096 1186 87.2% ±0.0%

Changed Class Coverage (3 classes)

Class Line Branch Method
g.e.Execution +0.1% 🟢 +4.2% 🟢 ±0.0%
g.GraphQLUnusualConfiguration
$DataloaderConfig
+37.5% 🟢 +100.0% 🟢 +40.0% 🟢
g.s.DataFetchingEnvironmentImpl +1.3% 🟢 +8.3% 🟢 ±0.0%

Full HTML report: build artifact jacoco-html-report

Updated: 2026-11-03 22:04:41 UTC

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bbakerman
bbakerman approved these changes Nov 4, 2026
View reviewed changes

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbakerman bbakerman bbakerman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

breaking change requires a new major version to be relased

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@andimarek @bbakerman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.