GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add comprehensive JSpecify @NullMarked annotations to remaining classes by Copilot · Pull Request #262 · graphql-java/java-dataloader

Conversation

Copilot AI commented Jan 28, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Completes JSpecify nullness annotation coverage across the library. Previously ~21 files were annotated; this adds annotations to the remaining ~32 files.

Changes

  • Core (Try, DataLoaderOptions, BatchLoaderContextProvider): Mark nullable throwable field, optional builder fields, nullable context return
  • Impl: nonNull() accepts @Nullable input; cause() returns @Nullable
  • Stats: Context parameters nullable for deprecated method compatibility
  • Instrumentation: beginXXX() methods return @Nullable; onCompleted params nullable
  • Scheduler: environment param marked @Nullable (null for simple loaders)
  • Reactive: callContexts list elements nullable

Type bound fix

// NoOpValueCache now matches ValueCache's type bound
public class NoOpValueCache<K, V extends @Nullable Object> implements ValueCache<K, V>

NullAway suppressions

Two suppressions for known generic type inference limitations:

  • AbstractBatchSubscriber.onError() — List<@Nullable Object> constructor
  • DataLoaderInstrumentationHelper.whenCompleted() — BiConsumer nullability

Other

  • Fixed KotlinExamples.kt explicit type params for stricter nullability
  • Updated JSPECIFY_MIGRATION_PLAN.md with completion status

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Initial plan
5bc117e
Copilot AI assigned Copilot and andimarek Jan 28, 2026
Copilot started work on behalf of andimarek January 28, 2026 23:41
View session
@andimarek
Add comprehensive JSpecify migration plan document
11e22a9
Co-authored-by: andimarek <[email protected]>
Copilot AI changed the title [WIP] Add comprehensive Jspecify annotations to java-dataloader Add JSpecify migration plan document Jan 28, 2026
Copilot AI requested a review from andimarek January 28, 2026 23:46
Copilot finished work on behalf of andimarek January 28, 2026 23:46
Copilot started work on behalf of andimarek January 28, 2026 23:47
View session
@andimarek
Expand effort estimate with detailed breakdown and justifications
bcfef7b
Co-authored-by: andimarek <[email protected]>
Copilot AI changed the title Add JSpecify migration plan document Add JSpecify migration plan with detailed effort estimates Jan 28, 2026
Copilot finished work on behalf of andimarek January 28, 2026 23:49
Copilot started work on behalf of andimarek January 28, 2026 23:51
View session
Copilot AI and others added 2 commits January 29, 2026 00:14
@andimarek
Add JSpecify @NullMarked annotations to all remaining files
34185f8
Co-authored-by: andimarek <[email protected]>
@andimarek
Address code review feedback: fix comment, restore license, add nulla…
2a6c04a
…ble to environment params

Co-authored-by: andimarek <[email protected]>
Copilot AI changed the title Add JSpecify migration plan with detailed effort estimates Add comprehensive JSpecify nullness annotations to all remaining classes Jan 29, 2026
Copilot finished work on behalf of andimarek January 29, 2026 00:26
Copilot started work on behalf of andimarek January 29, 2026 00:34
View session
Copilot AI changed the title Add comprehensive JSpecify nullness annotations to all remaining classes Add comprehensive JSpecify @NullMarked annotations to remaining classes Jan 29, 2026
Copilot finished work on behalf of andimarek January 29, 2026 00:36
@andimarek
andimarek marked this pull request as ready for review January 29, 2026 00:43
@github-actions

github-actions Bot commented Mar 30, 2026

Copy link
Copy Markdown

Hello, this pull request has been inactive for 60 days, so we're marking it as stale. If you would like to continue working on this pull request, please make an update within the next 30 days, or we'll close the pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the Stale label Mar 30, 2026
@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown

Hello, as this pull request has been inactive for 90 days, we're closing this pull request. We always welcome contributions, and if you would like to continue, please open a new pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot closed this Apr 29, 2026
@andimarek andimarek reopened this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andimarek andimarek Awaiting requested review from andimarek

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@andimarek andimarek

Copilot code review Copilot

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@andimarek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.