GeezerVison is showing github.com — Add comprehensive JSpecify @NullMarked annotations to remaining classes by Copilot · Pull Request #262 · graphql-java/java-dataloader
Conversation
Copilot
AI
commented
Jan 28, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Completes JSpecify nullness annotation coverage across the library. Previously ~21 files were annotated; this adds annotations to the remaining ~32 files.
Changes
- Core (
Try, DataLoaderOptions, BatchLoaderContextProvider): Mark nullable throwable field, optional builder fields, nullable context return
- Impl:
nonNull() accepts @Nullable input; cause() returns @Nullable
- Stats: Context parameters nullable for deprecated method compatibility
- Instrumentation:
beginXXX() methods return @Nullable; onCompleted params nullable
- Scheduler:
environment param marked @Nullable (null for simple loaders)
- Reactive:
callContexts list elements nullable
Type bound fix
// NoOpValueCache now matches ValueCache's type bound
public class NoOpValueCache<K, V extends @Nullable Object> implements ValueCache<K, V>
NullAway suppressions
Two suppressions for known generic type inference limitations:
AbstractBatchSubscriber.onError() — List<@Nullable Object> constructor
DataLoaderInstrumentationHelper.whenCompleted() — BiConsumer nullability
Other
- Fixed
KotlinExamples.kt explicit type params for stricter nullability
- Updated
JSPECIFY_MIGRATION_PLAN.md with completion status
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Copilot
AI
changed the title
[WIP] Add comprehensive Jspecify annotations to java-dataloader
Add JSpecify migration plan document
Jan 28, 2026
Copilot
AI
changed the title
Add JSpecify migration plan document
Add JSpecify migration plan with detailed effort estimates
Jan 28, 2026
Copilot
AI
changed the title
Add JSpecify migration plan with detailed effort estimates
Add comprehensive JSpecify nullness annotations to all remaining classes
Jan 29, 2026
Copilot
AI
changed the title
Add comprehensive JSpecify nullness annotations to all remaining classes
Add comprehensive JSpecify @NullMarked annotations to remaining classes
Jan 29, 2026
|
Hello, this pull request has been inactive for 60 days, so we're marking it as stale. If you would like to continue working on this pull request, please make an update within the next 30 days, or we'll close the pull request.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Hello, as this pull request has been inactive for 90 days, we're closing this pull request. We always welcome contributions, and if you would like to continue, please open a new pull request.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
andimarek
Awaiting requested review from andimarek
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|