GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Close JsonWriters. Caused speed up? · Issue #149 · hap-java/HAP-Java

Close JsonWriters. Caused speed up? #149

New issue
Copy link
New issue
Copy link
Closed
#158
Closed
Close JsonWriters. Caused speed up?#149
#158
Copy link

Description

@gjvanderheiden
gjvanderheiden
opened on Nov 18, 2021
Issue body actions

see:
[#148]

I use hap-java for my entire house. Everything is KNX, so pretty much accessories. Sometimes the accessories turn red and says "device not responding" (or something like that, get it in dutch). Also sometimes it takes a while, which makes no sense, because I cache all KNX values. I use a version with another pr request in it [#130]. Also I updated all dependencies in my local build of HAP-Java. No "device not responding" anymore and seems to react a lot faster.

So I'm not sure if closing JsonWriters did the trick. It can't hurt also. And in the close() operation of JsonWriter you see a flush. ByteArrayBuffer was closed, but that doesn't do anything.

I stole this idea from pr [#116]. That pr fixed it on one occurrence, but I found 3 more, by searching on usages of createWriter().

Activity

  1. gjvanderheiden commented on Jan 2, 2022

    @gjvanderheiden
    gjvanderheiden
    on Jan 2, 2022
    ContributorAuthor
    More actions

    Started my own hap implementation, pr requests are merged waaaay to slow.

  2. gjvanderheiden
    closed this as completedon Jan 2, 2022
  3. yfre
    linked a pull request that will close this issueclose JsonWriters #158on Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402520 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.