GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add optional Mute characteristic to Doorbell service by yfre · Pull Request #211 · hap-java/HAP-Java

Conversation

@yfre

@yfre yfre commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

What

DoorbellService now adds the optional Mute characteristic (11A) when the accessory implements AccessoryWithMute, like it already does for Name, Brightness and Volume. It also gets an addOptionalCharacteristic(MuteCharacteristic) overload.

Why

Mute is an optional characteristic of the Doorbell service (see the HAP-NodeJS Doorbell definition). The 2.0.1 changelog says "Add Mute characteristic to Doorbell service", but commit 40e0338 wired Mute into DoorService instead, and DoorbellService never got it.

Compatibility

Purely additive. Doorbells that don't implement AccessoryWithMute are unchanged.

DoorService keeps its Mute support: removing it would drop a public method, and nothing requires the change.

Testing

mvn -B package on JDK 11: all 23 tests pass. The new DoorbellServiceTest covers:

  • a doorbell without optional characteristics still exposes only the switch event
  • with AccessoryWithMute, the Mute characteristic is added, reports the accessory's state and forwards writes to setMute

Note: like #207, #209 and #210, this adds a # HAP-Java 2.0.10 section to CHANGES.md.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
udaw
Add optional Mute characteristic to Doorbell service
298f6dd
Mute is an optional characteristic of the Doorbell service. The 2.0.1
changelog lists it for the Doorbell service, but it was only wired into
DoorService. DoorService is left unchanged to stay compatible.
ccutrer
ccutrer approved these changes Oct 19, 2026
View reviewed changes
@yfre
yfre merged commit 46e2a02 into master Oct 19, 2026
1 check passed

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccutrer ccutrer ccutrer approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@yfre @ccutrer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.