GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Gracefully handle errors when binding SocketCAN fails by acolomb · Pull Request #1771 · hardbyte/python-can

Conversation

@acolomb

@acolomb acolomb commented Apr 24, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The parent class BusABC expects to be shutdown properly, checked via its self._is_shutdown flag during object deletion. But that flag is only set when the base class' shutdown() is called, which doesn't happen if instantiation of the concrete class failed in can.Bus(). So there is no way to avoid the warning message "SocketcanBus was not properly shut down" if the constructor raised an exception.

This change addresses that issue for the SocketCAN interface, by catching an OSError exception in bind_socket(), logging it, and calling self.shutdown() before re-raising the exception.

There might be a better approach which also works for the other backends? The flag could be initialized to True and only reset to False when the BusABC constructor runs (which happens last in derived classes)?

Thus leaving this as a draft for further discussion.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@acolomb
Gracefully handle errors when binding SocketCAN fails.
5e4e790
The parent class BusABC expects to be shutdown properly, checked via
its self._is_shutdown flag during object deletion.  But that flag is
only set when the base class shutdown() is called, which doesn't
happen if instantiation of the concrete class failed in can.Bus().  So
there is no way to avoid the warning message "SocketcanBus was not
properly shut down" if the constructor raised an exception.

This change addresses that issue for the SocketCAN interface, by
catching an OSError exception in bind_socket(), logging it, and
calling self.shutdown().
This was referenced Apr 24, 2024
Listener.stop() method breaks API since declared abstract #1770
Closed
Invert default value logic for BusABC._is_shutdown #1774
Merged
@acolomb
acolomb marked this pull request as ready for review April 25, 2024 07:37
@acolomb

acolomb commented Apr 25, 2024

Copy link
Copy Markdown
Contributor Author

The alternative approach is now proposed in #1774. This PR could still be useful in addition, to have a proper error log message. If that is desired...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hardbyte
hardbyte approved these changes Apr 29, 2024
View reviewed changes

@hardbyte hardbyte left a comment

Copy link
Copy Markdown
Owner

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this too - perhaps remove the comment and the shutdown call

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@acolomb
Remove shutdown call and obsolete comment.
813c39b
@acolomb

acolomb commented Apr 30, 2024

Copy link
Copy Markdown
Contributor Author

Adjusted as requested. Thanks for your consideration.

hardbyte reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@acolomb

acolomb commented Jun 13, 2024

Copy link
Copy Markdown
Contributor Author

Ping @hardbyte, want to merge this?

hardbyte reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hardbyte
hardbyte merged commit 2bc87c0 into hardbyte:main Jun 18, 2024
@acolomb
acolomb deleted the socketcan-shutdown-on-socket-error branch June 18, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hardbyte hardbyte hardbyte approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@acolomb @hardbyte
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.