GeezerVison is showing github.com — Gracefully handle errors when binding SocketCAN fails by acolomb · Pull Request #1771 · hardbyte/python-can
Conversation
acolomb
commented
Apr 24, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
The parent class BusABC expects to be shutdown properly, checked via its self._is_shutdown flag during object deletion. But that flag is only set when the base class' shutdown() is called, which doesn't happen if instantiation of the concrete class failed in can.Bus(). So there is no way to avoid the warning message "SocketcanBus was not properly shut down" if the constructor raised an exception.
This change addresses that issue for the SocketCAN interface, by catching an OSError exception in bind_socket(), logging it, and calling self.shutdown() before re-raising the exception.
There might be a better approach which also works for the other backends? The flag could be initialized to True and only reset to False when the BusABC constructor runs (which happens last in derived classes)?
Thus leaving this as a draft for further discussion.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The parent class BusABC expects to be shutdown properly, checked via
its self._is_shutdown flag during object deletion. But that flag is
only set when the base class shutdown() is called, which doesn't
happen if instantiation of the concrete class failed in can.Bus(). So
there is no way to avoid the warning message "SocketcanBus was not
properly shut down" if the constructor raised an exception.
This change addresses that issue for the SocketCAN interface, by
catching an OSError exception in bind_socket(), logging it, and
calling self.shutdown().
This was referenced Apr 24, 2024
|
The alternative approach is now proposed in #1774. This PR could still be useful in addition, to have a proper error log message. If that is desired...
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to merge this too - perhaps remove the comment and the shutdown call
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Adjusted as requested. Thanks for your consideration.
|
hardbyte reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
hardbyte reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
hardbyte
hardbyte approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.