GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add missing MathML tags for annotations. #183 by fred-wang · Pull Request #331 · html5lib/html5lib-python

Conversation

@fred-wang

@fred-wang fred-wang commented Apr 10, 2017

Copy link
Copy Markdown

New attempt, rebasing on top of master and restricting to annotations.

https://developer.mozilla.org/en-US/docs/Web/MathML/Element/semantics
https://www.w3.org/TR/MathML/chapter3.html#presm.semantics

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@fred-wang
Add missing MathML tags for annotations. html5lib#183
bdb6289
@willkg willkg added this to the 1.0 milestone Oct 3, 2017
@willkg

willkg commented Oct 31, 2017

Copy link
Copy Markdown
Contributor

The sanitizer is built to make sure the output is safe regardless of what the input was. So in order to approve adding these, I need to feel confident that these are safe to add.

There's this comment which you wrote that talks about the safety of adding these bits:

#181 (comment)

However, I don't know anything about MathML and can't evaluate that, so I can't approve this. We'll need someone who understands this to yay/nay it preferably with some proof. I'll hunt around and see if I can find someone I know.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@willkg

willkg commented Nov 6, 2017

Copy link
Copy Markdown
Contributor

I can't find anyone. I'm going to nix this from the 1.0 milestone.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@willkg willkg removed this from the 1.0 milestone Nov 6, 2017
@fred-wang

fred-wang commented Jun 5, 2018

Copy link
Copy Markdown
Author

@willkg What's the plan on this? Did you ask @jruderman ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@willkg

willkg commented Jun 5, 2018

Copy link
Copy Markdown
Contributor

@fred-wang I didn't find anyone, so I nixed it from the 1.0 milestone. After I got 1.0 out, I stepped off of this project.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gsnedders gsnedders added the sanitizer label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

sanitizer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@fred-wang @willkg @gsnedders
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.