GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow data: to not be part of sanitizer’s allowed protocols by charmander · Pull Request #412 · html5lib/html5lib-python

Conversation

@charmander

@charmander charmander commented Feb 21, 2019

Copy link
Copy Markdown

When data: wasn’t permitted, it could attempt to del attrs[attr] twice.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@charmander
Allow data: to not be part of sanitizer’s allowed protocols
e4757eb 
When `data:` wasn’t permitted, it could attempt to `del attrs[attr]` twice.
@codecov-io

codecov-io commented Feb 21, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #412 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #412   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files          50       50           
  Lines        6952     6952           
  Branches     1328     1328           
=======================================
  Hits         6312     6312           
  Misses        481      481           
  Partials      159      159
Impacted Files Coverage Δ
html5lib/filters/sanitizer.py 93.16% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f92357...e4757eb. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@twm

twm commented Mar 2, 2019

Copy link
Copy Markdown
Contributor

The change looks valid, but shouldn't there be a test case for this?
hugovk and ambv reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gsnedders gsnedders added the sanitizer label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

sanitizer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@charmander @codecov-io @twm @gsnedders
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.