GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove six by Mic92 · Pull Request #581 · html5lib/html5lib-python

Conversation

@Mic92

@Mic92 Mic92 commented Sep 9, 2024

Copy link
Copy Markdown

Depends on #580

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
a-detiste and selfisekai reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
Mic92 added 4 commits September 9, 2024 10:16
@Mic92
ruff: pyupgrade to 3.8
ef4c5ce 
ruff check --target-version py38 --select UP --fix .
@Mic92
manually remove fallback imports
fb864a9
@Mic92
only support pythons that are not EOL (https://endoflife.date/python)
29d3072 
Even debian oldstable has python 3.9. For internet-facing libraries it
is not secure for contributor to install unsupported python versions in order to test them.
Reducing the number of python versions will make maintenance and testing easier.
is not secure to contributor to install unsupported python versions in order to test them.
@Mic92
remove six
f90ee80
@Mic92

Mic92 commented Sep 9, 2024

Copy link
Copy Markdown
Author

I will continue to look at this when #580 is merged. Currently it still has some errors in it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ashleysommer

ashleysommer commented Sep 25, 2024

Copy link
Copy Markdown

Hi @Mic92
I am pulling this PR (and #580) into a custom html5lib fork for my personal project.
Can you tell me what errors you are still seeing after these commits?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ashleysommer ashleysommer mentioned this pull request Sep 25, 2024
remove six ashleysommer/html5lib-modern#2
Merged
@ashleysommer

ashleysommer commented Sep 25, 2024

Copy link
Copy Markdown

@Mic92 I found two, on line 133 and 135 of _inputstream.py you need to replace text_type with str.
After doing that, all tests pass.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mic92

Mic92 commented Sep 25, 2024

Copy link
Copy Markdown
Author

I was mainly looking at the test suite failing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mic92

Mic92 commented Sep 25, 2024

Copy link
Copy Markdown
Author

Good to know there is a potential fork to switch to in the future.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ashleysommer

ashleysommer commented Sep 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Good to know there is a potential fork to switch to in the future.

@Mic92
Its now published here:
https://pypi.org/project/html5lib-modern/
a-detiste reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Mic92 @ashleysommer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.