GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Stop treating ';' as part of an unquoted meta charset by ekanshul · Pull Request #608 · html5lib/html5lib-python

Conversation

@ekanshul

@ekanshul ekanshul commented Sep 30, 2026

Copy link
Copy Markdown

Unquoted charset values in a meta Content-Type currently stop only at ASCII whitespace. The HTML spec also treats ; as a terminator, so this markup:

<meta http-equiv="Content-Type" content="charset=iso-8859-2;text/html">

was parsed as the encoding name iso-8859-2;text/html and fell back to windows-1252.

ContentAttrParser.parse() now stops at whitespace or ;, matching https://html.spec.whatwg.org/#algorithm-for-extracting-a-character-encoding-from-a-meta-element.

Fixes #92

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ekanshul
Stop treating ';' as part of unquoted meta charset values
cd7173b 
The HTML spec stops an unquoted charset at ASCII whitespace or a
semicolon. ContentAttrParser only stopped at spaces, so values like
charset=iso-8859-2;text/html were treated as an invalid encoding.

Fixes html5lib#92
@shkyyy18 shkyyy18 mentioned this pull request Oct 1, 2026
Fix lxml treewalker for empty fragments #609
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Charset in meta content does not correctly parse for trailing semi-colon

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ekanshul
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.