GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Reduce docker image size and fix release GitHub action by nguyer · Pull Request #58 · hyperledger-firefly/dataexchange-https

Conversation

@nguyer

@nguyer nguyer commented Apr 26, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Nicko Guyer [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nguyer
Reduce docker image size and fix release GitHub action
097061b 
Signed-off-by: Nicko Guyer <[email protected]>
@nguyer
nguyer requested review from gabriel-indik and peterbroadhurst as code owners April 26, 2022 17:09
peterbroadhurst
peterbroadhurst reviewed Apr 26, 2022
View reviewed changes
Comment thread Dockerfile Outdated
FROM node:14-alpine3.11 as firefly-dataexchange-builder
RUN apk add --update python make
FROM node:16-alpine3.15 as firefly-dataexchange-builder
RUN apk add --update python3 make

@peterbroadhurst peterbroadhurst Apr 26, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we need python here or not

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@nguyer nguyer Apr 26, 2022

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out we do not. So I have removed it 🙂

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nguyer
Remove unnecessary build dependencies
3f0286b 
Signed-off-by: Nicko Guyer <[email protected]>
peterbroadhurst
peterbroadhurst approved these changes Apr 26, 2022
View reviewed changes

@peterbroadhurst peterbroadhurst left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - thanks for adding the 🐳 🗜️ in here, as well as fixing the action

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@peterbroadhurst
peterbroadhurst merged commit 46bf3cb into hyperledger-firefly:main Apr 26, 2022
@peterbroadhurst
peterbroadhurst deleted the build-enhancements branch April 26, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterbroadhurst peterbroadhurst peterbroadhurst approved these changes
@gabriel-indik gabriel-indik Awaiting requested review from gabriel-indik

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nguyer @peterbroadhurst
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.