GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — WIP - Example PR installing session handler without shared session module by TysonAndre · Pull Request #350 · igbinary/igbinary

Conversation

@TysonAndre

@TysonAndre TysonAndre commented Dec 4, 2021

Copy link
Copy Markdown
Member

This depends on the proposal for PHP 8.2 (php/php-src#7715)
to allow safely registering native session serializers even if the session
module isn't statically compiled into php
(without crashing if the session module isn't loaded or is loaded in the
wrong order, after the extension providing the serializer)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TysonAndre
WIP - Example PR installing session handler without shared session mo…
0a19944 
…dule

**This depends on the proposal for PHP 8.2 (php/php-src#7715)
to allow safely registering native session serializers even if the session
module isn't statically compiled into php
(without crashing if the session module isn't loaded or is loaded in the
wrong order, after the extension providing the serializer)
@TysonAndre
TysonAndre force-pushed the php8.2-session-dynamic branch from 7a734fe to 0a19944 Compare December 4, 2021 16:21
TysonAndre
TysonAndre commented Dec 4, 2021
View reviewed changes
Comment thread src/php7/igbinary.c
php_session_register_serializer("igbinary",
PS_SERIALIZER_ENCODE_NAME(igbinary),
PS_SERIALIZER_DECODE_NAME(igbinary));
#elif PHP_VERSION_ID >= 80200

@TysonAndre TysonAndre Dec 4, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: PHP_SESSION_API >= 20211204 probably makes more sense

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@TysonAndre
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.