GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Std. atrribute filtering and faceting support in client by anithakathir · Pull Request #20 · indix/indix-api-java

Conversation

@anithakathir

@anithakathir anithakathir commented Feb 20, 2017

Copy link
Copy Markdown
Member

@bbala-github

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
anithakathir added 3 commits February 17, 2017 15:50
@anithakathir
Add support for filtering by product attributes
e9d53cc
@anithakathir
Adds support for faceting by product attributes
0eba062
@anithakathir
Update SearchResult to include AttributeFacets
8b65d23
bbala-github
bbala-github reviewed Feb 20, 2017
View reviewed changes
Comment thread src/main/java/com/indix/query/SearchQuery.java

/**
* Combined with any of query/brand/category/store, limits results to products with specific attribute values
*/

@bbala-github bbala-github Feb 20, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should attrFilterKey contain the prefix 'attr.' or not on input?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anithakathir
Extracting out the std. attributes impl details
1b52655
bbala-github
bbala-github approved these changes Feb 20, 2017
View reviewed changes

@bbala-github bbala-github left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the minor comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
anithakathir added 3 commits February 24, 2017 16:21
@anithakathir
Merge branch 'master' into support-attr-filters-facets
57e2b3b
@anithakathir
Remove std attribute specifics while faceting
fb35aca
@anithakathir
Bump up client version and add feature usage in README
2b7a25e
bbala-github
bbala-github approved these changes Feb 27, 2017
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@bbala-github bbala-github bbala-github approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@anithakathir @bbala-github
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.