GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — clean up Dockerfile by paketb0te · Pull Request #83 · initialcommit-com/git-sim

Conversation

@paketb0te

@paketb0te paketb0te commented Apr 10, 2023

Copy link
Copy Markdown
Contributor

I saw that the Dockerfile installs git-sim from pip (RUN pip3 install git-sim), I think it makes more sense to copy the code and install it directly - hence this PR :)

While at it, I also removed some packages that are not required (python3-dev, and setting --no-install-recommends).

The syntax for calling git-sim in Docker does not change (-> no changes to README.md).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@paketb0te
clean up Dockerfile
aea4f9b
@initialcommit-io

initialcommit-io commented Apr 10, 2023

Copy link
Copy Markdown
Contributor

@paketb0te I'm inclined to leave it as is right now since it seems to be working (haven't had users report any issues with the docker install in a while).

Can you let me know the benefits of changing the current setup, including:

  • difference between the default python3 image and python3.10-bullseye
  • in manim installation page for linux it does say that python3-dev is a requirement. Is this already included in the base python image?
  • other pros/cons between the 2 setups

Thx!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@initialcommit-io

initialcommit-io commented Apr 10, 2023

Copy link
Copy Markdown
Contributor

@paketb0te Oh one other thing - if we are considering changing to specific Python version base image, why not use a 3.11 image to take advantage of the performance updates?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@paketb0te

paketb0te commented Apr 11, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author
* difference between the default python3 image and python3.10-bullseye

No difference, I just prefer using a specific version that will not change as much - using the tag python:3, you can not know if that image points to the 3.9.,3.10, 3.11, 3.12 version... (usually the latest stable, so probably 3.11 at the moment?)

* in [manim installation page for linux](https://docs.manim.community/en/stable/installation/linux.html) it does say that `python3-dev` is a requirement. Is this already included in the base python image?

Yes, the image has python installed already (kinda obvious, it's a python image after all :D ).

From my testing, the -dev version is not needed, and it helps to avoid having a duplicate python installation in the image.

* other pros/cons between the 2 setups

I think it makes more sense to build the image from source, instead of installing from pypi - we can a) build in parallel, if at some point we decide to publish the image to dockerhub (or any other registry), and b) it makes testing locally with docker possible when developing, (since we get the current source code in the container, not whatever is the latest version on pypi).

Agreed, these are all rather small reasons and I have no problems leaving things as-is, just thought it might be an easy, small improvement :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@paketb0te @initialcommit-io
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.