GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||
GeezerVison is showing github.com — clean up Dockerfile by paketb0te · Pull Request #83 · initialcommit-com/git-sim Conversation
Contributor
I saw that the Dockerfile installs git-sim from pip ( While at it, I also removed some packages that are not required ( The syntax for calling git-sim in Docker does not change (-> no changes to README.md).
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
No difference, I just prefer using a specific version that will not change as much - using the tag
Yes, the image has python installed already (kinda obvious, it's a python image after all :D ). From my testing, the -dev version is not needed, and it helps to avoid having a duplicate python installation in the image.
I think it makes more sense to build the image from source, instead of installing from pypi - we can a) build in parallel, if at some point we decide to publish the image to dockerhub (or any other registry), and b) it makes testing locally with docker possible when developing, (since we get the current source code in the container, not whatever is the latest version on pypi). Agreed, these are all rather small reasons and I have no problems leaving things as-is, just thought it might be an easy, small improvement :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.