GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix missing `six` dependency by UmanShahzad · Pull Request #13 · ipinfo/python

Conversation

@UmanShahzad

@UmanShahzad UmanShahzad commented May 31, 2019

Copy link
Copy Markdown
Contributor

Noticed it from ipinfo/django#3.

See commits for how it was missing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
UmanShahzad added 3 commits June 1, 2019 02:37
@UmanShahzad
Run black on the codebase.
6000250
@UmanShahzad
Fix issue with six not getting installed.
8862227
We were doing it via installing *pytest* before,
which although worked was definitely not preferable
because it meant users would get pytest in their
prod environments.

Now we will do it by explicitly putting six in there.

Eventually we will remove python2 support and can remove six.
@UmanShahzad
Patch fix version bump
d2b611f
@UmanShahzad UmanShahzad self-assigned this May 31, 2019
@UmanShahzad
UmanShahzad merged commit c3570c5 into master May 31, 2019
@UmanShahzad
UmanShahzad deleted the uman/fix-deps branch May 31, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@UmanShahzad UmanShahzad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@UmanShahzad
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.