GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Nest link annotation and underline within Link by rjcohn · Pull Request #9 · itext/itext-java

Conversation

@rjcohn

@rjcohn rjcohn commented Jan 16, 2017

Copy link
Copy Markdown
Contributor

Fix two separate problems:

  • Matterhorn 28-011: A link annotation is not nested within a Link tag.
  • Matterhorn 13-001: Graphics should be tagged (the condition says
    figure, but in this case it should be within the Link).
    See also: https://www.w3.org/TR/WCAG20-TECHS/PDF11.html
    Example 4: Marking up link text using a /Link structure element

The first problem is fixed by creating the Link in the structure
tree before creating the element for the annotation. The second is
fixed by closing the marked content after drawing the underline.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
pavel-morozov-duallab and others added 8 commits January 16, 2017 11:45
@pavel-morozov-duallab
Invalid byte position in .NET porting.
7ae46da
DEVSIX-987
@pavel-alay
FontSet refactoring. Move static fontNames cache to FontProgramInfo
19993ab
DEVSIX-314
@pavel-alay
Layout properties: add FONT_STYLE and FONT_WEIGHT.
45d9188
DEVSIX-1024
@pavel-alay
Save fontNames to cache in FontProgramInfo
2233ef1
DEVSIX-314
@yulian-gaponenko
Reimplement recent pull request ("Reverse order of Style lookup in Ab…
d33b3cb
…stractElement.getProperty.") in order to facilitate autoporting and avoid breaking of backward compatibility; also fix minor bug

In my opinion the best way to implement this would be to use an ArrayList and backward iterate it with a simple for-loop, however this would still break backward compatibility.
@Snipx
Get back original Apache header
82e484d
@rjcohn
Add test to show non-nesting of annot and underline for tagging
d793647
This test shows 2 problems:
- Matterhorn 28-011: A link annotation is not nested within a Link tag.
- Matterhorn 13-001: Graphics should be tagged (the condition says
  figure, but in this case it should be within the Link).
  See also:  https://www.w3.org/TR/WCAG20-TECHS/PDF11.html
    Example 4: Marking up link text using a /Link structure element
@rjcohn
Nest link annotation and underline within Link.
8014381
Fix two separate problems:
- Matterhorn 28-011: A link annotation is not nested within a Link tag.
- Matterhorn 13-001: Graphics should be tagged (the condition says
  figure, but in this case it should be within the Link).
  See also:  https://www.w3.org/TR/WCAG20-TECHS/PDF11.html
    Example 4: Marking up link text using a /Link structure element

The first problem is fixed by creating the Link in the structure
tree before creating the element for the annotation. The second is
fixed by closing the marked content after drawing the underline.
@amedee
amedee force-pushed the develop branch from 2a4f6a9 to bb542f3 Compare January 23, 2017 14:26
@blagae

blagae commented Jan 25, 2017

Copy link
Copy Markdown
Contributor

Hi @rjcohn,

This pull request has been rebased on top of the current develop branch. Thanks for your work !

Benoit

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@blagae blagae closed this Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@rjcohn @blagae @pavel-morozov-duallab @pavel-alay @yulian-gaponenko @Snipx
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.