GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add query to InsufficientParametersException by kennethtiller · Pull Request #418 · jasync-sql/jasync-sql

Conversation

@kennethtiller

@kennethtiller kennethtiller commented Nov 3, 2023

Copy link
Copy Markdown
Contributor

This PR adds query to InsufficientParametersException, to include the SQL in the exception message.

This makes it easier to find what code has failed with insufficient parameters by searching for the query in client codebase.

It can be hard to find the code because the asynchronous nature of the library does not include stacktrace to call site.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kenneth-tiller
added query to InsufficientParametersException
fff11f7
@kennethtiller kennethtiller changed the title Added query to InsufiicientParametersException Add query to InsufiicientParametersException Nov 3, 2023
@kennethtiller kennethtiller mentioned this pull request Nov 7, 2023
Hard to find calling site in client code based on current InsufficentParametersException implementation #420
Closed
@oshai

oshai commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

Thanks for the PR! can you please add a test for it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kenneth-tiller
added assertions for message to existing tests
4a511f7
@kennethtiller

kennethtiller commented Nov 8, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the PR! can you please add a test for it?

Thanks for asking! I found it to be a natural fit for the existing tests, have a look and let me know if you'd like it another way
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kenneth-tiller
more idiomatic kotlin
869a805
@oshai

oshai commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

lgtm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kennethtiller kennethtiller changed the title Add query to InsufiicientParametersException Add query to InsufficientParametersException Nov 8, 2023
@oshai
oshai merged commit 83029e5 into jasync-sql:master Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kennethtiller @oshai
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.