GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: default LittleEndianByteBufAllocator to pooled allocator and release row slices on error by oshai · Pull Request #448 · jasync-sql/jasync-sql

Conversation

@oshai

@oshai oshai commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Default LittleEndianByteBufAllocator to PooledByteBufAllocator.DEFAULT (accepting any ByteBufAllocator and delegating isDirectBufferPooled) and wire LittleEndianByteBufAllocator(configuration.allocator) in MySQLConnectionHandler so direct buffers (such as SslHandler / netty-tcnative) use pooled allocation rather than unpooled direct memory.
  • Release all retained ResultSetRowMessage column ByteBuf slices in an outer finally block in MySQLConnectionHandler so a decode exception on an earlier column cannot leak remaining column slices.

Fixes #435

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@oshai
fix: default LittleEndianByteBufAllocator to pooled allocator and rel…
f3fa935 
…ease row slices on error
@oshai
oshai merged commit d429902 into master Nov 9, 2026
2 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@oshai
oshai deleted the fix/issue-435-pooled-allocator-row-leak branch November 9, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LittleEndianByteBufAllocator uses UnpooledByteBufAllocator is not optimal and potentially causing OOM error

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@oshai
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.