GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Propagate I/O failures from UnifiedDiffWriter by jakezwang · Pull Request #234 · java-diff-utils/java-diff-utils

Conversation

@jakezwang

@jakezwang jakezwang commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

The Writer overload logs and swallows IOException, allowing a partially written diff to look successful to the caller.

Bridge the exception through the Consumer overload with UncheckedIOException, then rethrow the original IOException. Regression tests fail during header, body and trailer output, including newline writes, and verify that writing stops immediately.

Validation: mvn -B -ntp clean package passes on JDK 8 and 17, including formatting, Checkstyle, both modules and Javadoc (156 tests, 3 skipped). All four new cases fail before the fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jakezwang added 2 commits September 18, 2026 21:10
@jakezwang
Propagate I/O failures from UnifiedDiffWriter
e3e13e9
@jakezwang
Document no-op methods in failing writer test
c6905d8
@wumpz
wumpz merged commit 1b449db into java-diff-utils:master Oct 9, 2026
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jakezwang @wumpz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.