GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixes #32: Doubt about writeEscapedString() by lukasj · Pull Request #70 · javaee/jsonp

This repository was archived by the owner on Nov 7, 2024. It is now read-only.

Conversation

@lukasj

@lukasj lukasj commented Oct 30, 2017

Copy link
Copy Markdown
Member

reworked writeEscapedString to work with code points

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lukasj
#32: Doubt about writeEscapedString()
7229fad 
Signed-off-by: Lukas Jungmann <[email protected]>
@lukasj
lukasj requested a review from m0mus October 30, 2017 17:35
@m0mus m0mus added this to the 1.1.2 milestone Oct 31, 2017
@m0mus

m0mus commented Oct 31, 2017

Copy link
Copy Markdown
Member

@bravehorsie please review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@m0mus
m0mus requested a review from bravehorsie October 31, 2017 23:32
m0mus
m0mus reviewed Oct 31, 2017
View reviewed changes

@m0mus m0mus left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bravehorsie

bravehorsie commented Nov 1, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Looks good to me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bravehorsie
bravehorsie reviewed Nov 1, 2017
View reviewed changes

@bravehorsie bravehorsie left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an excellent candidate for performance test.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@m0mus m0mus modified the milestones: 1.1.2, 1.1.3 Nov 2, 2017
@glassfishrobot glassfishrobot mentioned this pull request Feb 12, 2018
Place holder issue for Pull Request 70 jakartaee/jsonp-api#70
Closed
@keilw

keilw commented Oct 3, 2018

Copy link
Copy Markdown
Member

Is this still done here or should the repository also be archived (like the README actually says)?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lukasj

lukasj commented Oct 3, 2018

Copy link
Copy Markdown
Member Author

@keilw this was archived but we found an issue which needs to be fixed, so we unarchived this and will archive it (and port all changes to ee4j) once its done. Makes sense?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@m0mus m0mus m0mus left review comments
@bravehorsie bravehorsie bravehorsie left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.1.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lukasj @m0mus @bravehorsie @keilw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.