GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Test for programmatic-registration module is incorrect · Issue #320 · javaee-samples/javaee7-samples

Test for programmatic-registration module is incorrect #320

New issue
Copy link
New issue
Copy link
Open
Open
Test for programmatic-registration module is incorrect#320
Copy link

Description

@orelgenya
orelgenya
opened on Sep 15, 2015
Issue body actions

This test wrong at many points:

  • test returns before calling ParentServlet, which is responsible for ChildServlet registration;
  • webclient calls wrong URLs (/ is redundant and don't match with mappings);
  • mapping for ChildServlet isn't set (dynamically)
  • fail(..) statement prevents execution of meaningful part of the test;
  • and finally it wouldn't work because programmatic registration is impossible after ServletContext initialization is finished.

Activity

  1. arun-gupta commented on Sep 15, 2015

    @arun-gupta
    arun-gupta
    on Sep 15, 2015
    Contributor
    More actions

    Send a PR with the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.