GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Minor fixes to close json resources, prevent malformed URLs, and correct index.xhtml values by rbrinkster · Pull Request #313 · javaee-samples/javaee7-samples

Conversation

@rbrinkster

@rbrinkster rbrinkster commented Jun 22, 2015

Copy link
Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rbrinkster added 9 commits June 22, 2015 15:59
@rbrinkster
Remove double slashes before faces
344be71 
In some situations, the base will end without an ending slash, but in other cases it will end with a slash, so the replace should take care of issues with double slashes.
@rbrinkster
Remove double slashes before faces
71ccc33 
In some situations, the base will end without an ending slash, but in other cases it will end with a slash, so the replace should take care of issues with double slashes.
@rbrinkster
Remove double slashes before faces
8705ff6 
In some situations, the base will end without an ending slash, but in other cases it will end with a slash, so the replace should take care of issues with double slashes.
@rbrinkster
Switched selectBooleanCheckbox to selectManyCheckbox in appropriate a…
d20d81b 
…reas

In the selectManyListbox and selectManyMenu components, I updated selectBooleanCheckbox to selectManyCheckbox to account for the requirement that a list or array must be provided as the value.
@rbrinkster
Added close statements for jsonReader
f65b7e7
@rbrinkster
Added close statements for jsonReader
0b1d511
@rbrinkster
Added close statements for parser
6885adf
@rbrinkster
Added close statements for parser
66c17bf
@rbrinkster
Updated tests with corrections to assertions
c1e334f
@rbrinkster

rbrinkster commented Jun 24, 2015

Copy link
Copy Markdown
Author

Yes, so to answer the question on usecases, I am running the samples with both the june beta of liberty as well as glassfish. I can't get the samples that use the faces api to work on glassfish, but in liberty the base URL has an ending slash, so it conflicts with the addition of '/faces'. I thought the best way to get around this without causing conflict would be to replace '//faces' with '/faces' to avoid double slashes.

Now, on the updated assertions, I also could not get these samples to run on glassfish, so I wasn't able to crosscheck against liberty. Liberty failed the tests on those assertions, but returned the new strings that I added. They seem slightly more descriptive than the old assertions, so I thought there might've been an update somewhere.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arun-gupta

arun-gupta commented Jun 24, 2015

Copy link
Copy Markdown
Contributor

Can you test these against WildFly and see how they behave? If they are failing against GlassFish then @m-reza-rahman can help you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rbrinkster

rbrinkster commented Jun 24, 2015

Copy link
Copy Markdown
Author

I will run those tests in the morning and give you an update.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rbrinkster
rbrinkster force-pushed the master branch from 49f8fde to c1e334f Compare June 24, 2015 04:15
@arjantijms

arjantijms commented Jun 24, 2015

Copy link
Copy Markdown
Contributor

I thought the best way to get around this without causing conflict would be to replace '//faces' with '/faces' to avoid double slashes.

I didn't look at the exact usage of /faces, but if it's for mapping purposes a general advice is to use .xhtml to .xhtml mapping. This will be the default in JSF 2.3 anyway, and for 2.2 and earlier can be realized with a simple servlet mapping.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rbrinkster

rbrinkster commented Jun 24, 2015

Copy link
Copy Markdown
Author

Okay, so I ran the tests against Wildfly this morning. The replacement to avoid double slashes worked fine, but the assertions that I updated are different than they were on liberty. I'm not sure why the returned values for the assertions are different or which one of them is technically correct, so if you have any input there it would be greatly appreciated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arun-gupta

arun-gupta commented Jul 2, 2015

Copy link
Copy Markdown
Contributor

@rbrinkster are you saying that the assertions for WildFly and Liberty Profile are different?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rbrinkster

rbrinkster commented Jul 3, 2015

Copy link
Copy Markdown
Author

Yes, they are different. Apparently the spec does not require the returned messages to be identical. The only thing that must be identical is the returned code from my understanding.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arun-gupta

arun-gupta commented Jul 3, 2015

Copy link
Copy Markdown
Contributor

That seems like a spec inconsistency. Can you file issue for that?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arun-gupta

arun-gupta commented Jul 16, 2015

Copy link
Copy Markdown
Contributor

@rbrinkster have you filed the spec issue? I'd like to close this request after that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rbrinkster

rbrinkster commented Jul 18, 2015

Copy link
Copy Markdown
Author

Hi Arun, my apologies for the delay in getting back to you. I have communicated this issue to the IBM expert group reps responsible for Bean Validation and JSF. They will be taking care of opening up a spec issue if needed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arun-gupta

arun-gupta commented Jul 19, 2015

Copy link
Copy Markdown
Contributor

Lets clarify that this is indeed the issue, otherwise this change may not be valid.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@rbrinkster @arun-gupta @arjantijms
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.