GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — JASPIC ServerAuthModule and ServerAuthContext spec compliance fixes by stoty · Pull Request #375 · javaee-samples/javaee7-samples

Conversation

@stoty

@stoty stoty commented Jan 5, 2017

Copy link
Copy Markdown

This contains two sets of fixes:

  • The SAMs no longer return SUCCESS with emtpy principals for mandatory
    authentication
  • The ServerAuthContext sets up two SAM module instances to satisfy the
    spec requirement that the mandatory flag can be accessed from the
    requestPolicy

The first fix is important, as currently the tests fail to return proper
http status codes for unathenticated protected resources on multiple app
servers.

The second fix is just for complying with the letter of the spec, as the
requestPolicy is not actually used in any of the current tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@stoty
JASPIC ServerAuthModule and ServerAuthContext spec compliance fixes
a687b2f 
This contains two sets of fixes:
- The SAMs no longer return SUCCESS with emtpy principals for mandatory
authentication
- The ServerAuthContext sets up two SAM module instances to satisfy the
spec requirement that the mandatory flag can be accessed from the
requestPolicy

The first fix is important, as currently the tests fail to return proper
http status codes for unathenticated protected resources on multiple app
servers.

The second fix is just for complying with the letter of the spec, as the
requestPolicy is not actually used in any of the current tests.
@arjantijms

arjantijms commented Jan 11, 2017

Copy link
Copy Markdown
Contributor

I've glanced over the PR and it looks good at first sight, but I'm very busy now with JSF 2.3 (final day before it closes). But haven't forgotten about this PR ;) Will look at it soon in more detail.

Thanks for now!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@stoty @arjantijms
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.