GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Formbased authentication corrupts post params payara by albfernandez · Pull Request #429 · javaee-samples/javaee7-samples

Conversation

albfernandez commented Jan 28, 2018

Copy link

Copy Markdown

This testcase reproduces Payara bug

payara/Payara#2318

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

albfernandez added 2 commits

January 26, 2018 19:30


          First attemp to reproduce parameter corruption in Payara

69d8b87

See payara/Payara#2318 for mor details.

I've reproduced the bug in Payara 4.1.2.174, but this first version on
Arquillian works as expected.


          Fix the test to reproduce payara bug

3a557d5

payara/Payara#2318

albfernandez mentioned this pull request

Jan 28, 2018

Fix FormAuthenticator corrupting post parameters. payara/Payara#2320

Merged

albfernandez commented Jan 29, 2018

Copy link

Copy Markdown

Author

The failing test is the expected behaviour: It's the payara bug we're trying to reproduce

Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 23.829 sec <<< FAILURE! - in org.javaee7.servlet.security.form.based.FormTest
testMaintainPostParamsAfterAuth(org.javaee7.servlet.security.form.based.FormTest) Time elapsed: 0.474 sec <<< FAILURE!
org.junit.ComparisonFailure: expected:<[7]> but was:<[251]>
at org.javaee7.servlet.security.form.based.FormTest.testMaintainPostParamsAfterAuth(FormTest.java:108)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

arjantijms commented Jan 30, 2018

Copy link

Copy Markdown

Contributor

Looks good, will pull in as soon as we have the fix for Payara in. Thx!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

albfernandez commented Nov 17, 2018

Copy link

Copy Markdown

Author

This sample should pass the test now ,
from the pom.xml <payara.version>4.1.2.181</payara.version>, version which fixed de bug

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'master' into formbased_authentication_corrupts_post_par…

affedbf

…ams_payara

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.