GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Simple edit to Garbage collection arabic translation by Ahmed-Adel3 · Pull Request #81 · javascript-tutorial/ar.javascript.info

Conversation

Ahmed-Adel3 commented Jun 12, 2020

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Simple edit to Garbage collection arabic translation

2dec06c

javascript-translate-bot added the review needed label

Jun 12, 2020

javascript-translate-bot requested a review from a team

June 12, 2020 08:06


          Translate coding styles page to AR

c1fae73

3imed-jaberi requested changes

Jun 12, 2020

View reviewed changes

3imed-jaberi left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ahmed-Adel3, thank you for your PR.

Check my suggestion.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/03-code-quality/02-coding-style/1-style-errors/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/1-style-errors/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/1-style-errors/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/1-style-errors/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Jun 12, 2020

javascript-translate-bot commented Jun 12, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

3imed-jaberi requested review from Jamil-Bailony and OmarioHassan

June 12, 2020 14:03

Ahmed-Adel3 and others added 20 commits

June 12, 2020 16:07


          Update 1-js/03-code-quality/02-coding-style/1-style-errors/solution.md

4ee4fd4

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/1-style-errors/solution.md

797447c

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

5a6a98b

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

9b9e7a6

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

9e73cd6

Co-authored-by: imed jaberi <[email protected]>


          Merge branch 'master' into object-basics

becd098


          Update 1-js/03-code-quality/02-coding-style/article.md

bc703d8

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

2c13a15

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

1a50e4f

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/1-style-errors/solution.md

bab1997

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

66694ad

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

caa3414

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

cef8bc9

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

cfcbc7e

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

0e883b0

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

33ee0e3

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

eb1bc2d

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

290e7c6

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/1-style-errors/solution.md

c360626

Co-authored-by: imed jaberi <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

189a82c

Co-authored-by: imed jaberi <[email protected]>

3imed-jaberi requested changes

Jun 15, 2020

View reviewed changes

3imed-jaberi left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing small typo to fix and it's ready to merge 🚀 ..

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Jun 15, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          fix last think

a43bcd8

3imed-jaberi approved these changes

Jun 17, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed changes requested labels

Jun 17, 2020

3imed-jaberi merged commit fed6de2 into javascript-tutorial:master

Jun 17, 2020

iliakan mentioned this pull request

Jun 17, 2020

Arabic Translation Progress #1

Open

Ahmed-Adel3 commented

Jun 18, 2020

View reviewed changes

Ahmed-Adel3 left a comment

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Reviewers

3imed-jaberi

3imed-jaberi approved these changes

Jamil-Bailony

Awaiting requested review from Jamil-Bailony

OmarioHassan

Awaiting requested review from OmarioHassan

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.