GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Functions · Pull Request #29 · javascript-tutorial/bn.javascript.info

Conversation

ghost commented Oct 28, 2019

Copy link

Copy Markdown

I have translated all the files (assigned to me) completely. Please, check those change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

lifeoflikhon added 9 commits

October 21, 2019 11:29


          translated local variable

ed22f5b


          translated outer variable

f1b273d


          translated parameters

cd8a2d3


          default parameters

2cdbd53


          translated returnting value

e4071e8


          translated naming function

82e7a01


          translated Function == Comments

f69beb9


          translated Summary

277dd96


          translating Function DONE

4b6de63

javascript-translate-bot added the review needed label

Oct 28, 2019

javascript-translate-bot requested a review from a team

October 28, 2019 11:06

CLAassistant commented Oct 28, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

raikusy changed the title ~~Translating Function DONE~~ Functions

Oct 29, 2019

iliakan mentioned this pull request

Oct 29, 2019

Bengali Translation Progress #1

Open

raikusy commented Oct 29, 2019

Copy link

Copy Markdown

Contributor

@lifeoflikhon ধন্যবাদ আপনার কন্ট্রিবিউশন এর জন্য। পুল রিকুয়েস্ট দেয়ার সময়, পুল রিকুয়েস্ট এর টাইটেল আপনি যে চ্যাপ্টার অনুবাদ করেছেন, হুবহু সেটির টাইটেল হতে হবে, এর সাথে অন্য কিছু লেখা যাবে না। আমি এটি আপডেট করে দিয়েছি। ভবিষ্যতে খেয়াল রাখবেন। 😄

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

raikusy requested changes

Oct 29, 2019

View reviewed changes

raikusy left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

বেশ কিছু জায়গায় কোড এর ফরম্যাটিং পরিবর্তন হয়েছে, কোথাও স্পেস কেটে গেছে, কোথাও ডাবল কোট সিঙ্গেল কোট হয়ে গেছে। মুল লেখা থেকে কোডের অংশটুকু তে কোন পরিবর্তন করা যাবে না। শুধু মাত্র কমেন্ট গুলি অনুবাদ করা যেতে পারে। কিন্তু কোন প্রকার লিন্টিং/প্রিটিয়ার করা যাবে না। অনুবাদ করার সময় এডিটর এর ডিফল্ট লিন্টিং/প্রিটিয়ার ডিসেবল করে রাখতে হবে।
ধন্যবাদ।

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/14-function-basics/2-rewrite-function-question-or/solution.md Outdated

		```js
		function checkAge(age) {
		return (age > 18) \|\| confirm('Did parents allow you?');
		return age > 18 \|\| confirm('Did parents allow you?');

raikusy Oct 29, 2019

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	return age > 18 \|\| confirm('Did parents allow you?');
	return (age > 18) \|\| confirm('Did parents allow you?');

কোডের স্টাইল চেঞ্জ করা যাবে না।

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/14-function-basics/article.md Outdated

		```js
		function showMessage() {
		alert( 'Hello everyone!' );
		alert('Hello everyone!');

raikusy Oct 29, 2019

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	alert('Hello everyone!');
	alert( 'Hello everyone!' );

কোড স্টাইল পরিবর্তন করা যাবে না।

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/14-function-basics/article.md Outdated

		!
		let message = "Hello, I'm JavaScript!"; // লোকাল ভ্যারিয়েবল
		/!
		alert(message);

raikusy Oct 29, 2019

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

মুল লেখার সাথে লাইন নাম্বার পরিবর্তন হয়ে গেছে। ৬৩ নাম্বার লাইন খালি থাকার কথা। এছাড়া মুল কোড এর স্টাইল ও পরিবর্তন হয়েছে। মুল কোড কে লিন্ট/প্রিটিয়ার করা যাবে না।

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot removed the review needed label

Oct 29, 2019

javascript-translate-bot commented Oct 29, 2019

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Oct 29, 2019

raikusy commented Nov 3, 2019

Copy link

Copy Markdown

Contributor

@lifeoflikhon পরিবর্তন গুলি আপডেট করে /done লিখে কমেন্ট করে জানাবেন। আমরা তাহলে পুনরায় রিভিউ করতে পারবো।
ধন্যবাদ।

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          translated done

29c7606

ghost commented Nov 7, 2019

Copy link

Copy Markdown

Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Nov 7, 2019

javascript-translate-bot requested a review from a team

November 7, 2019 20:25

raikusy approved these changes

Nov 15, 2019

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Nov 15, 2019

raikusy merged commit 021a741 into javascript-tutorial:master

Nov 15, 2019

javascript-translate-bot commented Nov 15, 2019

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ghost commented Oct 28, 2019

Uh oh!

CLAassistant commented Oct 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raikusy commented Oct 29, 2019

Uh oh!

raikusy left a comment

Choose a reason for hiding this comment

Uh oh!

raikusy Oct 29, 2019

Choose a reason for hiding this comment

Uh oh!

raikusy Oct 29, 2019

Choose a reason for hiding this comment

Uh oh!

raikusy Oct 29, 2019

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Oct 29, 2019

Uh oh!

raikusy commented Nov 3, 2019

Uh oh!

ghost commented Nov 7, 2019

Uh oh!

javascript-translate-bot commented Nov 15, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Oct 28, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.