GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — WeakMap and WeakSet by behrends · Pull Request #196 · javascript-tutorial/de.javascript.info

Conversation

@behrends

@behrends behrends commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@behrends
WeakMap and WeakSet
451dff3
@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Dec 15, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team December 15, 2023 16:45
@javascript-translate-bot javascript-translate-bot mentioned this pull request Dec 15, 2023
German Translation Progress #1
Open
J-Cake
J-Cake requested changes Dec 16, 2023
View reviewed changes

@J-Cake J-Cake left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/05-data-types/08-weakmap-weakset/01-recipients-read/solution.md Outdated
Das `WeakSet` ermöglicht es, eine Menge von Nachrichten zu speichern und einfach zu überprüfen, ob eine Nachricht darin existiert.

It cleans up itself automatically. The tradeoff is that we can't iterate over it, can't get "all read messages" from it directly. But we can do it by iterating over all messages and filtering those that are in the set.
Es bereinigt sich automatisch. Der Kompromiss ist, dass wir nicht darüber iterieren können, wir können "alle gelesenen Nachrichten" daraus nicht direkt erhalten. Aber wir können dies erreichen, indem wir über alle Nachrichten iterieren und diejenigen filtern, die in der Menge sind.

@J-Cake J-Cake Dec 16, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die Übersetzung passt zum Kontext nicht. Hier ist warscheinlich maschinell übersetzt worden?

*... indem wir über alle Nachrichten iterieren und diejenigen aussortieren, die nicht im Set sind.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/05-data-types/08-weakmap-weakset/02-recipients-when-read/solution.md

@J-Cake J-Cake Dec 16, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variabeln sollten möglichst ungeändert bleiben

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/05-data-types/08-weakmap-weakset/02-recipients-when-read/task.md Outdated
```

The question now is: which data structure you'd suggest to store the information: "when the message was read?".
Die Frage lautet nun: Welche Datenstruktur würdest Du vorschlagen, um die Information zu speichern: „Wann wurde die Nachricht gelesen?“.

@J-Cake J-Cake Dec 16, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die besonderen Anführungszeichten gefallen mir, aber ist nicht konsistent mit der bisherigen Übersetzungsleistung... Müsste leider auch geändert werden :(

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Dec 16, 2023
@javascript-translate-bot

javascript-translate-bot commented Dec 16, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@behrends
Make requested changes
7bdd01c
@behrends

behrends commented Dec 17, 2023

Copy link
Copy Markdown
Contributor Author

Done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@J-Cake
J-Cake merged commit 4032b78 into javascript-tutorial:master Dec 17, 2023
@javascript-translate-bot

javascript-translate-bot commented Dec 17, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@J-Cake J-Cake J-Cake requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

changes requested Waiting for changes and /done from PR author

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@behrends @javascript-translate-bot @J-Cake
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.