GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Logical operators by SirCodewright · Pull Request #26 · javascript-tutorial/de.javascript.info

Conversation

SirCodewright commented Mar 17, 2020

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

SirCodewright added 30 commits

March 17, 2020 13:24


          Update task.md

f3e240f


          Update article.md

be76b2d


          First draft

e5ca2f2

truthy/falsy -> effektiv wahr/unwahr. 'Effektiv falsch' has the connotation of being inadmissible semantically in a more pronounced way than 'effektiv true' has it for being semantically admissible; therefore 'effektiv unwahr' has been chosen for 'falsy'.


          Update solution.md

f96d32c


          Update task.md

2d243ad


          Update solution.md

4c51d03


          Update solution.md

b7aa5b6


          Update task.md

b8067c6


          Update solution.md

b0d0d01


          Update solution.md

b98325f


          Improved wording

e449c42

'effektiv unwahr' -> 'effektiv nicht wahr'. General rationale for translation of 'falsy' see previous commit.


          Update task.md

bec3118


          Update solution.md

4a6af62


          Update task.md

f4c2547


          Update solution.md

fe43dbf


          Update task.md

d69a0b4


          Update task.md

160179e


          Update task.md

c07bd39


          Update solution.md

a538cff


          Update task.md

6971d47


          Update solution.md

b531c02


          Update task.md

ed48368


          Update solution.md

3be9e1c


          Update task.md

b49ff9f


          Update ifelse_task.svg

34990ad


          Update ifelse_task.svg

1155f22


          Update ifelse_task.svg

f1e7c21


          Update ifelse_task.svg

9117c09


          Update ifelse_task.svg

6c20930


          Update ifelse_task.svg

fc8f68b

javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label

Apr 5, 2020

SirCodewright and others added 7 commits

April 5, 2020 16:53


          Review issues / update javascript-tutorial#1

a712245

Co-Authored-By: Christian Hegedüs <[email protected]>


          Review issues / update javascript-tutorial#2

3fc6693

Co-Authored-By: Christian Hegedüs <[email protected]>


          Review issues / update javascript-tutorial#1

4fe03cb

Co-Authored-By: Christian Hegedüs <[email protected]>


          Review issues / update javascript-tutorial#4

fa2d1aa

Co-Authored-By: Christian Hegedüs <[email protected]>


          Review issues / update javascript-tutorial#5

d2a7712

Co-Authored-By: Christian Hegedüs <[email protected]>


          Review issues / update javascript-tutorial#6

4f9a965

Co-Authored-By: Christian Hegedüs <[email protected]>


          Review issues / update javascript-tutorial#7

33f1edb

Co-Authored-By: Christian Hegedüs <[email protected]>

SirCodewright commented Apr 5, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels

Apr 5, 2020

javascript-translate-bot requested a review from a team

April 5, 2020 15:17


          Merge branch 'master' into master

087c67e

ghost approved these changes

Apr 19, 2020

View reviewed changes

javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels

Apr 19, 2020

christianhegedues requested changes

Apr 20, 2020

View reviewed changes

christianhegedues left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es tut mir leid, mir sind da noch drei Sachen aufgefallen. Wenn du diese noch anpassenen könntest, wäre das super - danach können wir es gleich mergen.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/11-logical-operators/7-check-if-out-range/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/11-logical-operators/7-check-if-out-range/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/11-logical-operators/8-if-question/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label

Apr 20, 2020

javascript-translate-bot commented Apr 20, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ghost approved these changes

Apr 21, 2020

View reviewed changes

javascript-translate-bot removed the changes requested Waiting for changes and /done from PR author label

Apr 21, 2020

SirCodewright and others added 3 commits

April 21, 2020 12:48


          Review round javascript-tutorial#2 200420 / update javascript-tutorial#1

ec4644f



Co-Authored-By: Christian Hegedüs <[email protected]>


          Review round javascript-tutorial#2 200420 / update javascript-tutorial#2

e8f1d7d



Co-Authored-By: Christian Hegedüs <[email protected]>


          Review round javascript-tutorial#2 200420 / update javascript-tutorial#3

360200d



Co-Authored-By: Christian Hegedüs <[email protected]>

SirCodewright commented Apr 21, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the review needed Review needed, please approve or request changes label

Apr 21, 2020

javascript-translate-bot requested a review from a team

April 21, 2020 10:50

christianhegedues approved these changes

Apr 21, 2020

View reviewed changes

christianhegedues merged commit 6ced657 into javascript-tutorial:master

Apr 21, 2020

javascript-translate-bot commented Apr 21, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

christianhegedues

christianhegedues approved these changes

+1 more reviewer

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

One more review needed

review needed

Review needed, please approve or request changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.