GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Variables by JoeGab · Pull Request #9 · javascript-tutorial/de.javascript.info

Conversation

@JoeGab

@JoeGab JoeGab commented Jan 19, 2020

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JoeGab added 3 commits January 19, 2020 03:17
@JoeGab
Haupttext und Kommentare übersetzt
d152500
@JoeGab
fixed typos
4210d0a
@JoeGab
translate the tasks
54fefa2
@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Jan 19, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team January 19, 2020 04:22
@iliakan iliakan mentioned this pull request Jan 19, 2020
German Translation Progress #1
Open
@claassistantio

claassistantio commented Jan 19, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JoeGab

JoeGab commented Jan 19, 2020

Copy link
Copy Markdown
Contributor Author

I didn't create the svg translations, wasn't sure if it is working for those? I also didn't translate the english code snippets except for the descriptional comments. Should I?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iliakan

iliakan commented Jan 19, 2020

Copy link
Copy Markdown
Member

@JoeGab There's a special way to translate SVGs ;) We can do that later, when more text is ready for publishing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JoeGab

JoeGab commented Jan 19, 2020

Copy link
Copy Markdown
Contributor Author

okay cool! Let me know, I'll help =)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1H0
1H0 suggested changes Jan 20, 2020
View reviewed changes
Comment thread 1-js/02-first-steps/04-variables/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/02-first-steps/04-variables/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/02-first-steps/04-variables/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Jan 20, 2020
@javascript-translate-bot

javascript-translate-bot commented Jan 20, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JoeGab and others added 3 commits January 20, 2020 12:56
@JoeGab @1H0
Update 1-js/02-first-steps/04-variables/article.md
bcb0fc9 
Co-Authored-By: Lukas <[email protected]>
@JoeGab @1H0
Update 1-js/02-first-steps/04-variables/article.md
e1f0e68 
Co-Authored-By: Lukas <[email protected]>
@JoeGab @1H0
Update 1-js/02-first-steps/04-variables/article.md
912673f 
Co-Authored-By: Lukas <[email protected]>
@JoeGab

JoeGab commented Jan 20, 2020

Copy link
Copy Markdown
Contributor Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jan 20, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team January 20, 2020 11:59
1H0
1H0 approved these changes Jan 20, 2020
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels Jan 20, 2020
@1H0
1H0 merged commit f707218 into javascript-tutorial:master Jan 20, 2020
@javascript-translate-bot

javascript-translate-bot commented Jan 20, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@1H0 1H0 added ready to merge and removed needs +1 One more review needed labels Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@1H0 1H0 1H0 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JoeGab @claassistantio @iliakan @javascript-translate-bot @1H0
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.