GeezerVison is showing github.com — Fix `\u{X…XXXXXX}` description: a hexadecimal value, not "1 to 6 bytes" by 1t1sCooL · Pull Request #3975 · javascript-tutorial/en.javascript.info
Conversation
1t1sCooL
commented
Jul 2, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
The \u{X…XXXXXX} escape takes hexadecimal digits, not bytes: the maximum code point 10FFFF is 6 hex digits, which is 3 bytes.
Following the review feedback, the digit-count limit is now dropped as well. The spec does not cap the number of hex digits inside \u{…} — it only requires the resulting value to be at most 0x10FFFF. For instance "\u{0000001}" has seven digits and is perfectly valid, so "1 to 6 digits" would have been inaccurate in its own way. The value range alone conveys everything that matters.
Spotted via the Russian translation (javascript-tutorial/ru.javascript.info#2124), where the same wording was faithfully translated along with the mistake. The Russian side is updated in javascript-tutorial/ru.javascript.info#2175.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
CLAassistant
commented
Jul 2, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
All committers have signed the CLA.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81024abeaf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
Good catch, thanks — fixed in 17ba8ad.
The spec doesn't cap the number of hex digits inside \u{…}; it only requires the resulting value to be at most 0x10FFFF. So "\u{0000001}" is valid and yields code point 1, which the "1 to 6" wording wrongly rejected.
I dropped the digit-count clause altogether rather than saying "at most six significant digits" — the value range already carries all the information that matters:
X…XXXXXX must be a hexadecimal value between 0 and 10FFFF (the highest code point defined by Unicode).
Note the original text was inaccurate on a second count as well: it said "1 to 6 bytes", where the escape actually takes hex digits. That was the reason for this PR in the first place.
The same sentence in the Russian translation is updated in javascript-tutorial/ru.javascript.info#2175 to keep the two in sync.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
1t1sCooL
changed the title
Fix "1 to 6 bytes" to "1 to 6 hex digits" in \u{X…XXXXXX} description
Fix \u{X…XXXXXX} description: a hexadecimal value, not "1 to 6 bytes"
Aug 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|