GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs(fetch): add modern `Promise.allSettled` solution to fetch-users task by illia-m-b · Pull Request #3987 · javascript-tutorial/en.javascript.info

Conversation

@illia-m-b

@illia-m-b illia-m-b commented Aug 5, 2026

Copy link
Copy Markdown

Closes #3986

Description

Appends a production-grade alternative solution to the "Fetch users from GitHub" task.

Changes Made

  • Appended an "Alternative modern approach" section to solution.md.
  • Added a code snippet utilizing Promise.allSettled, async callbacks, and object destructuring.

Technical Rationale

The original solution intentionally mixes .then() with await for educational purposes. This addition complements the lesson by demonstrating current industry best practices:

  • Pure async/await syntax without chained Promise methods.
  • Graceful fault tolerance for network failures via Promise.allSettled.
  • Independent, non-blocking fetch execution.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Aug 5, 2026
@javascript-translate-bot
javascript-translate-bot requested a review from a team August 5, 2026 18:13
AKzar1el
AKzar1el reviewed Nov 2, 2026
View reviewed changes

@AKzar1el AKzar1el left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue in the new runnable alternative: the request URL is malformed, so the example will not fetch the intended GitHub user endpoint. I inspected the PR's current source and the existing solution; I did not run the tutorial's test suite.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 5-network/01-fetch/01-fetch-users/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@illia-m-b
docs(fetch): add modern Promise.allSettled solution to fetch-users …
b0e6413 
…task (javascript-tutorial#3986)
@illia-m-b
illia-m-b force-pushed the patch-1 branch from 55fed0a to b0e6413 Compare November 11, 2026 07:36
@illia-m-b

illia-m-b commented Nov 11, 2026

Copy link
Copy Markdown
Author

@AKzar1el Thanks. I've addressed this. Please take a look when you have a moment.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@AKzar1el AKzar1el AKzar1el left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

review needed Review needed, please approve or request changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Proposal: Add modern Promise.allSettled alternative to "Fetch users" task solution

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@illia-m-b @AKzar1el @javascript-translate-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.