GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Ninja code by Sjesc · Pull Request #109 · javascript-tutorial/es.javascript.info

Conversation

Sjesc commented Oct 4, 2019

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Sjesc added 3 commits

October 2, 2019 22:53


          Update fork (#3)

768f2ab

Update fork


          Traducir articulo ninja code

757bd6b


          terminar traduccion del articulo

d31b843

javascript-translate-bot added the review needed label

Oct 4, 2019

javascript-translate-bot requested a review from a team

October 4, 2019 23:14

iliakan mentioned this pull request

Oct 4, 2019

Spanish Translation Progress #17

Open

EzequielCaste requested changes

May 30, 2020

View reviewed changes

EzequielCaste left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corregir

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Outdated

		A fellow programmer who wants to work with `elem` in the second half of the function will be surprised... Only during the debugging, after examining the code they will find out that they're working with a clone!

		Seen in code regularly. Deadly effective even against an experienced ninja.
		Un compañero de programación que quiera trabajar con `elem` en la segunda mitad de la función será sorprendido... Solo durante la depuración, después de examinar el código encontrara que está trabajando con un clon.

EzequielCaste May 30, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	Un compañero de programación que quiera trabajar con `elem` en la segunda mitad de la función será sorprendido... Solo durante la depuración, después de examinar el código encontrara que está trabajando con un clon.
	Un colega programador que quiera trabajar con `elem` en la segunda mitad de la función será sorprendido... Solo durante la depuración, después de examinar el código encontrara que está trabajando con un clon.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

May 30, 2020

javascript-translate-bot commented May 30, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

EzequielCaste requested a review from joaquinelio

May 30, 2020 20:16

joaquinelio requested changes

May 30, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se ve lindo.
@ezzep66 , ¿seguimos con doble revisión?
Lo hice encima de la tuya así apenas se corrige la podés subir.
Si pensás que no hacen falta, disculpas.

La gramática no es el tema más importante en JS. Ni siquiera para la virtual machine jeje

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented May 30, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

EzequielCaste commented Jun 1, 2020

Copy link

Copy Markdown

Contributor

qué se hace si @Sjesc no responde?

podemos nosotros maintainers corregir?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'master' into ninja-code-2

2c30d17

vplentinax commented Jun 5, 2020

Copy link

Copy Markdown

Contributor

Si, tenemos que corregir @ezzep66 @joaquinelio

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax and others added 12 commits

June 6, 2020 00:44


          Update 1-js/03-code-quality/04-ninja-code/article.md

55b0703

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/03-code-quality/04-ninja-code/article.md

8d66ef6

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/03-code-quality/04-ninja-code/article.md

0bfb298

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/03-code-quality/04-ninja-code/article.md

4b859ed

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/03-code-quality/04-ninja-code/article.md

6403c9c

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/03-code-quality/04-ninja-code/article.md

131d030

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/03-code-quality/04-ninja-code/article.md

82e2a7b

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/03-code-quality/04-ninja-code/article.md

4ab0735

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/03-code-quality/04-ninja-code/article.md

7e4afd4

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/03-code-quality/04-ninja-code/article.md

4a958df

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/03-code-quality/04-ninja-code/article.md

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/03-code-quality/04-ninja-code/article.md

6eea635

Co-authored-by: Ezequiel Castellanos <[email protected]>

joaquinelio approved these changes

Jun 7, 2020

View reviewed changes

javascript-translate-bot removed the changes requested label

Jun 7, 2020

javascript-translate-bot added the needs +1 label

Jun 7, 2020

joaquinelio and others added 3 commits

June 7, 2020 02:12


          Apply suggestions from code review

071d440

11 sugerencias ok

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update article.md

d80ddf0


          Update article.md

bef085b

joaquinelio merged commit fd721d0 into javascript-tutorial:master

Jun 7, 2020

javascript-translate-bot commented Jun 7, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

EzequielCaste

EzequielCaste requested changes

joaquinelio

joaquinelio approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.