GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Strings by ferueda · Pull Request #126 · javascript-tutorial/es.javascript.info

Conversation

ferueda commented Dec 6, 2019

Copy link

Copy Markdown

Contributor

String article and tests (tasks and solutions) translated to spanish.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ferueda added 4 commits

November 28, 2019 08:15


          translating string article to spanish

cecac71


          continued translating article Strings

65b4eaa


          finished last translation review

10090b8


          finished article and tests

1678cc1

javascript-translate-bot added the review needed label

Dec 6, 2019

javascript-translate-bot requested a review from a team

December 6, 2019 23:12

spideep suggested changes

Dec 10, 2019

View reviewed changes

Comment thread

1-js/05-data-types/03-string/2-check-spam/solution.md

		alert( checkSpam("innocent rabbit") );
		alert( checkSpam('compra ViAgRA ahora') );
		alert( checkSpam('xxxxx gratis') );
		alert( checkSpam("coneja inocente") );

ferueda Dec 10, 2019

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No entiendo el cambio solicitado aquí.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

spideep reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

1-js/05-data-types/03-string/article.md Outdated

		# Strings

		In JavaScript, the textual data is stored as strings. There is no separate type for a single character.
		En JavaScript, los datos textuales son almacenados como strings (cadena de caracteres). No hay un tipo de datos separado para caracteres únicos.

spideep Dec 10, 2019

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'unitarios' en lugar de 'únicos'. Puesto que se refiere a la cantidad de caracteres no a la exclusividad.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot removed the review needed label

Dec 10, 2019

javascript-translate-bot commented Dec 10, 2019

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Dec 10, 2019

ferueda commented

Dec 10, 2019

View reviewed changes

Comment thread

1-js/05-data-types/03-string/2-check-spam/solution.md

		alert( checkSpam("innocent rabbit") );
		alert( checkSpam('compra ViAgRA ahora') );
		alert( checkSpam('xxxxx gratis') );
		alert( checkSpam("coneja inocente") );

ferueda Dec 10, 2019

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No entiendo el cambio solicitado aquí.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

spideep reacted with thumbs up emoji

All reactions

👍 1 reaction


          changed únicos for unitarios

c23397a

ferueda commented Dec 13, 2019

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Dec 13, 2019

ferueda commented Jan 7, 2020

Copy link

Copy Markdown

Contributor Author

It looks like no one is reviewing these pull requests from the community. If you need help revewing them I can help as a reviewer.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio changed the title ~~Strings article translated to spanish~~ Strings

Jun 8, 2020

iliakan mentioned this pull request

Jun 8, 2020

Spanish Translation Progress #17

Open


          Merge branch 'master' into master

a3dfe10

joaquinelio requested changes

Jun 17, 2020

View reviewed changes

joaquinelio left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cambié Un mont+on!!!!!!!!!! Falta ahora:

Restaurar un ejercicio (lo marqué)
79 - Restaurar una tabla y retraducirla.(faltan items y descripciones)
135, 150 - Revisar formato con inglés: el suggest arruina los marckup triple comilla `
VOLVERÉ con un editor bueno

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio added 3 commits

June 17, 2020 06:16


          Apply suggestions from code review

1f96e20

37 cambios que me atreví a hacer sin permiso
tildes, gramática, y err de concepto mas lineas que no habian sido traducidas adrede


          Update article.md

10be5cb

Actualización grossa


          Update article.md

ed4d11c

ortografía

joaquinelio approved these changes

Jun 18, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed changes requested labels

Jun 18, 2020

joaquinelio merged commit fb3b99c into javascript-tutorial:master

Jun 18, 2020

javascript-translate-bot commented Jun 18, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio approved these changes

+1 more reviewer

spideep

spideep requested changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ferueda commented Dec 6, 2019

Uh oh!

ferueda Dec 10, 2019

Choose a reason for hiding this comment

Uh oh!

spideep Dec 10, 2019

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Dec 10, 2019

Uh oh!

ferueda Dec 10, 2019

Choose a reason for hiding this comment

Uh oh!

ferueda commented Dec 13, 2019

Uh oh!

ferueda commented Jan 7, 2020

Uh oh!

joaquinelio left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jun 17, 2020

Uh oh!

javascript-translate-bot commented Jun 18, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

joaquinelio left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.