GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — WeakMap and WeakSet by vplentinax · Pull Request #176 · javascript-tutorial/es.javascript.info

Conversation

vplentinax commented May 10, 2020

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added the review needed label

May 10, 2020

javascript-translate-bot requested a review from a team

May 10, 2020 06:22

iliakan mentioned this pull request

May 10, 2020

Spanish Translation Progress #17

Open


          WeakMap and WeakSet

01abb36

cortizg reviewed

Jun 9, 2020

View reviewed changes

cortizg left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discrepo en dejar Array en las traducciones, este review lo dejo como comentario, pero hay unas traducciones pequeñas que se pasaron por alto como "Like this"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/weakmap-weakset/01-recipients-read/solution.md

		Otra solución diferente podría ser agregar una propiedad como `message.isRead = true` a un mensaje después de leerlo. Como los objetos de mensajes son administrados por otro código, generalmente se desaconseja, pero podemos usar una propiedad simbólica para evitar conflictos.

		Like this:
		```js

cortizg Jun 9, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Como esto:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/weakmap-weakset/01-recipients-read/task.md


		---

		# Almacenar banderas "no leídas"

cortizg Jun 9, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mencionaba Joaquin que banderas se deja como flags, tal como hace MDN

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/weakmap-weakset/01-recipients-read/task.md

		# Almacenar banderas "no leídas"

		Hay un array de mensajes:

cortizg Jun 9, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array es arreglo, incluso MDN dice arreglo

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/weakmap-weakset/02-recipients-when-read/task.md


		# Almacenar fechas de lectura

		Hay un array semejante al de la actividad anterior [previous task](info:task/recipients-read). La sitación es similar:

cortizg Jun 9, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array es arreglo https://developer.mozilla.org/es/docs/Glossary/Arreglos

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/weakmap-weakset/02-recipients-when-read/task.md Outdated


		En la tarea anterior solo necesitábamos almacenar el hecho de "sí / no". Ahora necesitamos almacenar la fecha, y solo debe permanecer en la memoria hasta que el mensaje sea recolectado como basura.

		P.D Las fechas se pueden almacenar como objetos de la clase incorporada `Fecha`, que cubriremos más adelante.

cortizg Jun 9, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

la clase incorporada (builtin) se llama Date: OJO

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/weakmap-weakset/article.md


		Por lo general, las propiedades de un objeto o elementos de un array u otra estructura de datos se consideran accesibles y se mantienen en la memoria mientras esa estructura de datos permanezca en la memoria.

		Por ejemplo, si colocamos un objeto en un array, mientras el array esté vivo, el objeto también estará vivo, incluso si no hay otras referencias a él.

cortizg Jun 9, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array es arreglo https://developer.mozilla.org/es/docs/Glossary/Arreglos

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/weakmap-weakset/article.md

		john = null; // sobrescribe la referencia

		!
		// John se almacena dentro del array, por lo que no será recolectado por el recolector de basura

cortizg Jun 9, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

busqueda y reemplazo con editor de texto array por arreglo

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

cortizg suggested changes

Jun 9, 2020

View reviewed changes

cortizg left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

traducciones que pasaron por alto y un typo

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/weakmap-weakset/01-recipients-read/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/weakmap-weakset/02-recipients-when-read/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Jun 9, 2020

javascript-translate-bot commented Jun 9, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax and others added 4 commits

June 10, 2020 19:28


          Update 1-js/05-data-types/weakmap-weakset/article.md

46913d1

Co-authored-by: Carlos Ortiz Gutiérrez <[email protected]>


          Update 1-js/05-data-types/weakmap-weakset/article.md

50372ba

Co-authored-by: Carlos Ortiz Gutiérrez <[email protected]>


          Update 1-js/05-data-types/weakmap-weakset/02-recipients-when-read/tas…

114d816

…k.md

Co-authored-by: Carlos Ortiz Gutiérrez <[email protected]>


          Update 1-js/05-data-types/weakmap-weakset/01-recipients-read/solution.md

1c9082b

Co-authored-by: Carlos Ortiz Gutiérrez <[email protected]>

joaquinelio approved these changes

Jun 14, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un par de cositas tipo "suggest" nomás.
Abandono la pelea de glosario array. Cambialo o no, then merge sin asco.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/weakmap-weakset/01-recipients-read/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added needs +1 and removed changes requested labels

Jun 14, 2020

EzequielCaste and others added 7 commits

June 15, 2020 18:24


          Update 1-js/05-data-types/weakmap-weakset/article.md

7ec5e4b

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/weakmap-weakset/article.md

e8a6054

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/weakmap-weakset/article.md

1fa8c93

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/weakmap-weakset/article.md

af3268f

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/weakmap-weakset/article.md

826a7ef

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/weakmap-weakset/article.md

c66d582

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/05-data-types/weakmap-weakset/01-recipients-read/solution.md

6c6d71a

Co-authored-by: joaquinelio <[email protected]>

EzequielCaste merged commit a4edb73 into javascript-tutorial:master

Jun 15, 2020

javascript-translate-bot commented Jun 15, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio approved these changes

+1 more reviewer

cortizg

cortizg requested changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.