GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Property flags and descriptors by kenliten · Pull Request #183 · javascript-tutorial/es.javascript.info

Conversation

kenliten commented May 12, 2020

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Property flags and descriptors

6075c98

javascript-translate-bot added the review needed label

May 12, 2020

javascript-translate-bot requested a review from a team

May 12, 2020 03:16

CLAassistant commented May 12, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iliakan mentioned this pull request

May 12, 2020

Spanish Translation Progress #17

Open


          Merge branch 'master' into master

d8b3d1b

EzequielCaste requested changes

Jun 24, 2020

View reviewed changes

EzequielCaste left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hay problemas con el número de las líneas a partir de línea 127. Verificar con artículo original EN

Alguna sugerencia?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/07-object-properties/01-property-descriptors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/07-object-properties/01-property-descriptors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/07-object-properties/01-property-descriptors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Jun 24, 2020

javascript-translate-bot commented Jun 24, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Jun 24, 2020

vplentinax and others added 3 commits

June 25, 2020 14:52


          Update 1-js/07-object-properties/01-property-descriptors/article.md

eed1c43

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/07-object-properties/01-property-descriptors/article.md

531b243

Co-authored-by: Ezequiel Castellanos <[email protected]>


          Update 1-js/07-object-properties/01-property-descriptors/article.md

52788c2

Co-authored-by: Ezequiel Castellanos <[email protected]>

vplentinax commented Jun 25, 2020

Copy link

Copy Markdown

Contributor

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax previously requested changes

Jun 25, 2020

View reviewed changes

vplentinax left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le faltaron partes por traducir. Las estructuras coinciden EN vs ES

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/07-object-properties/01-property-descriptors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/07-object-properties/01-property-descriptors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Jun 25, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax added 2 commits

June 30, 2020 13:26


          Update 1-js/07-object-properties/01-property-descriptors/article.md

5eea71f


          Update 1-js/07-object-properties/01-property-descriptors/article.md

befa1fe

vplentinax commented Jun 30, 2020

Copy link

Copy Markdown

Contributor

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax commented Jun 30, 2020

Copy link

Copy Markdown

Contributor

Volver a revisar

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax added the review needed label

Jun 30, 2020

joaquinelio added 2 commits

June 30, 2020 20:05


          Update article.md

840c9ae

añadido triple grave linea 127


          Update article.md

654c618

Editado smart header y contenido  251 - 254

joaquinelio approved these changes

Jun 30, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edité el archivo directamente, dejo registro:
127 agregado formato gravegravegrave,
no se puede hacer suggest porque el triple tilde lo cierra y borraria la linea
251-254 ??? el smart header es completamente distinto...
dejo en coment el original y también edito directamente por la misma razon del triple tilde.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/07-object-properties/01-property-descriptors/article.md Outdated

		Notable exception: a value of non-configurable, but writable property can be changed.

		The idea of `configurable: false` is to prevent changes to property flags and its deletion, not changes to its value.
		```smart header="Los errores aparecen solo en uso estricto"

joaquinelio Jun 30, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original 251-252
___smart header="Los errores aparecen solo en uso estricto"
En el modo no estricto, no aparecen errores al escribir en propiedades de solo lectura y semejantes. Pero la operación no será ejecutada. Las acciones viola-identificadores son silenciadas e ignoradas en modo no estricto.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed changes requested review needed labels

Jun 30, 2020


          Update article.md

b2c4ded

fix a la edición de 254

EzequielCaste approved these changes

Jul 1, 2020

View reviewed changes

EzequielCaste left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo bien salvo algunas correcciones

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/07-object-properties/01-property-descriptors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/07-object-properties/01-property-descriptors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/07-object-properties/01-property-descriptors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update 1-js/07-object-properties/01-property-descriptors/article.md

c1db644

EzequielCaste added 2 commits

July 1, 2020 10:52


          Update 1-js/07-object-properties/01-property-descriptors/article.md

ec8915b


          Update 1-js/07-object-properties/01-property-descriptors/article.md

74c5820

EzequielCaste dismissed vplentinax’s stale review

July 1, 2020 13:53

ya fue revisado

EzequielCaste merged commit 02780d9 into javascript-tutorial:master

Jul 1, 2020

Reviewers

joaquinelio

joaquinelio approved these changes

EzequielCaste

EzequielCaste approved these changes

vplentinax

vplentinax left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

kenliten commented May 12, 2020

Uh oh!

CLAassistant commented May 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EzequielCaste left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jun 24, 2020

Uh oh!

vplentinax commented Jun 25, 2020

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jun 25, 2020

Uh oh!

vplentinax commented Jun 30, 2020

Uh oh!

vplentinax commented Jun 30, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

joaquinelio Jun 30, 2020

Choose a reason for hiding this comment

Uh oh!

EzequielCaste left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CLAassistant commented May 12, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.