GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Prototype methods, objects without __proto__ by cortizg · Pull Request #195 · javascript-tutorial/es.javascript.info

Conversation

cortizg commented May 18, 2020

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added the review needed label

May 18, 2020

javascript-translate-bot requested a review from a team

May 18, 2020 01:26

iliakan mentioned this pull request

May 18, 2020

Spanish Translation Progress #17

Open


          1-08-04-pm Traducido 15

d96e8e1

1-08-04-pm Corregido 14

1-08-04-pm Corregido 15

joaquinelio requested changes

May 25, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bien, sugiero el rearmado de algunas frases.

no se si se debe modificar
index.md (se usa como link, aunque también para mostrar menú)
los svg (y que no sé cómo probar desde acá) creo haber leído que se llaman con parámetros y no se debían modificar pero no pude encontrar dónde.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/08-prototypes/04-prototype-methods/2-dictionary-tostring/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/04-prototype-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/04-prototype-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/04-prototype-methods/2-dictionary-tostring/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/04-prototype-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/04-prototype-methods/article.md Outdated


		```js
		// fully identical shallow clone of obj
		// clon superficial totalmente idéntico de obj

joaquinelio May 25, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no entiendo por qué puso shallow, es obj es simplemente "idéntico", nada más. salvo que signifique copia llana. no lo pondría. Tembién me molesta la redundancia del original, pero lo quiere sobresalir de la copia via loop que sí es superficial.

// clon totalmente idéntico de obj

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

cortizg May 30, 2020

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

EzequielCaste May 30, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"shallow" es para identificar que no tiene objetos anidados en su interior

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio reacted with thumbs up emoji

All reactions

👍 1 reaction

joaquinelio May 30, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡AAAGGH!
DISCULPEN la falta de atención. metí un err donde no lo había
Debería poner un PR al inglés, poque "idéntico" confunde,
hay obj copiados superficialmente (es CORRECTA la palabra) por lo tanto NO idénticos,
y obj copiados recursivamente , IDÉNTICO y no superficial , creí que se refería a esto

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

cortizg May 30, 2020

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿seria entonces: clon superficial totalmente idéntico a obj?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

joaquinelio May 30, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PFFF
si yo estuviera estudiando esto, abandonaría

quizas sea que la capa superficial sí es idéntica
(porque podrías copiar solo prop y metodos y dejar sin copiar el resto)

No me animo a corregir, tengo que repasar el tema. Haciendo pruebas.
@ezzep66 sí parece entenderlo

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

EzequielCaste May 30, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fully identical >> totalmente idéntico
shallow clone >> clon superficial
of obj >> de obj

clon superficial de obj totalmente idéntico
me parece...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

cortizg May 30, 2020

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok: clon superficial de obj totalmente idéntico

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/08-prototypes/04-prototype-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/04-prototype-methods/article.md Outdated

		- [Object.setPrototypeOf(obj, proto)](mdn:js/Object.setPrototypeOf) - establece el `[[Prototype]]` de `obj` en `proto` (igual que el setter de `__proto__`).

		The built-in `__proto__` getter/setter is unsafe if we'd want to put user-generated keys in to an object. Just because a user may enter "__proto__" as the key, and there'll be an error with hopefully easy, but generally unpredictable consequences.
		El getter/setter incorporado de `__proto__` no es seguro si queremos poner claves generadas por el usuario en un objeto. Aunque un usuario puede ingresar `"__proto __"` como clave, y habrá un error, con consecuencias levemente esperanzadoras, pero generalmente impredecibles.

joaquinelio May 25, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( ) , y habrá un error, con consecuencias, con esperanza tranquilas pero generalmente impredecibles.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

cortizg May 30, 2020

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

EzequielCaste May 30, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yo diría
con consecuencias levemente fáciles, pero generalmente impredecibles.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

joaquinelio May 30, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eehhhmm...
qué significa "levemente fácil". Definitiva y rotundamente y un completo CREO QUE NO :)

Uno pone el parche, potencialmente peligroso. entonces
"easy" acá no es "fácil" sino "suave" ("easy, boy" cuando tranquilizás al perro)
hopefully easy
"consecuencias que, esperamos, sean leves/imperceptibles/no dañinas."
"con suerte, consecuencias leves o nulas" menos literal

take it easy

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

cortizg May 30, 2020

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

se escucha mejor!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/08-prototypes/04-prototype-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/index.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

May 25, 2020

javascript-translate-bot commented May 25, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

May 25, 2020


          revisión 2020-05-29

e8f41e7

cortizg commented May 30, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

May 30, 2020

cortizg added 2 commits

May 30, 2020 12:59


          revision 2020-05-30

ad49226


          revision 2020-05-30 2

9d22f63

joaquinelio reviewed

May 30, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezzep66
"apruebo"
pero no me animo a "approve"
tengo miedo que haga un merge automático
¿seguimos alimentando el repo? ¿probamos, pongo approve y vemos si el bot hace merge?
porque todavía no sabemos como manejar el repo actual

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          revision 2020-05-30 3

0b52022

EzequielCaste approved these changes

May 30, 2020

View reviewed changes

EzequielCaste left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

May 30, 2020

EzequielCaste commented May 30, 2020

Copy link

Copy Markdown

Contributor

1 change requested
@joaquinelio
joaquinelio requested changes

me queda colgado eso...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio approved these changes

May 30, 2020

View reviewed changes

joaquinelio commented May 30, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Aprobé sin leer jaja ¿está hecho? Lead this, @ezzep66 te dejo el merge porque en un punto me supera.
Siempre se puede corregir, si cabe.

el bot gerentea más de lo que pensaba,
el traductor debería poner comentario /done en lugar de "listo/ok", y el bot lo manda a rerevisar

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'master' into es.javascript.info.1-08-04-pm

c1a6bfb

vplentinax merged commit 39af0cc into javascript-tutorial:master

Jun 3, 2020

javascript-translate-bot commented Jun 3, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio approved these changes

EzequielCaste

EzequielCaste approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

cortizg commented May 18, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joaquinelio May 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented May 25, 2020

Uh oh!

cortizg commented May 30, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

EzequielCaste left a comment

Choose a reason for hiding this comment

Uh oh!

EzequielCaste commented May 30, 2020

Uh oh!

joaquinelio commented May 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javascript-translate-bot commented Jun 3, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

joaquinelio May 30, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio commented May 30, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.